Drop support for http body dot bytes response checksums

Author: 0marperez

codegen/protocol-tests/build.gradle.kts

@@ -25,19 +25,19 @@ data class ProtocolTest(val projectionName: String, val serviceShapeId: String,
 val enabledProtocols = listOf(
     ProtocolTest("aws-ec2-query", "aws.protocoltests.ec2#AwsEc2"),
 
-    // FIXME: Re-enable. These test are broken after an update: https://github.com/smithy-lang/smithy/pull/2467
+    // FIXME: Re-enable. This test is broken after a smithy update: https://github.com/smithy-lang/smithy/pull/2467
     // ProtocolTest("aws-json-10", "aws.protocoltests.json10#JsonRpc10"),
 
     ProtocolTest("aws-json-11", "aws.protocoltests.json#JsonProtocol"),
 
-    // FIXME: Re-enable. These test are broken after an update: https://github.com/smithy-lang/smithy/pull/2403
-//    ProtocolTest("aws-restjson", "aws.protocoltests.restjson#RestJson"),
-//    ProtocolTest("aws-restxml", "aws.protocoltests.restxml#RestXml"),
+    // FIXME: Re-enable. These tests are broken after a smithy update: https://github.com/smithy-lang/smithy/pull/2403
+    // ProtocolTest("aws-restjson", "aws.protocoltests.restjson#RestJson"),
+    // ProtocolTest("aws-restxml", "aws.protocoltests.restxml#RestXml"),
 
     ProtocolTest("aws-restxml-xmlns", "aws.protocoltests.restxml.xmlns#RestXmlWithNamespace"),
     ProtocolTest("aws-query", "aws.protocoltests.query#AwsQuery"),
 
-    // FIXME: Re-enable. These test are broken after an update: https://github.com/smithy-lang/smithy/pull/2467
+    // FIXME: Re-enable. This test is broken after a smithy update: https://github.com/smithy-lang/smithy/pull/2467
     // ProtocolTest("smithy-rpcv2-cbor", "smithy.protocoltests.rpcv2Cbor#RpcV2Protocol"),
 
     // Custom hand written tests

runtime/protocol/http-client/common/src/aws/smithy/kotlin/runtime/http/interceptors/FlexibleChecksumsResponseInterceptor.kt

@@ -12,7 +12,6 @@ import aws.smithy.kotlin.runtime.client.config.HttpChecksumConfigOption
 import aws.smithy.kotlin.runtime.collections.AttributeKey
 import aws.smithy.kotlin.runtime.hashing.toHashFunction
 import aws.smithy.kotlin.runtime.http.HttpBody
-import aws.smithy.kotlin.runtime.http.readAll
 import aws.smithy.kotlin.runtime.http.request.HttpRequest
 import aws.smithy.kotlin.runtime.http.response.HttpResponse
 import aws.smithy.kotlin.runtime.http.response.copy
@@ -90,31 +89,14 @@ public class FlexibleChecksumsResponseInterceptor<I>(
             .removePrefix("x-amz-checksum-")
             .toHashFunction() ?: throw ClientException("Could not parse checksum algorithm from header $checksumHeader")
 
-        if (context.protocolResponse.body is HttpBody.Bytes) {
-            logger.debug { "Validating checksum before deserialization from $checksumHeader" }
+        logger.debug { "Validating checksum during deserialization from $checksumHeader" }
 
-            // Calculate checksum
-            checksumAlgorithm.update(
-                context.protocolResponse.body.readAll() ?: byteArrayOf(),
-            )
-            val sdkChecksumValue = checksumAlgorithm.digest().encodeBase64String()
-
-            validateAndThrow(
-                serviceChecksumValue,
-                sdkChecksumValue,
-            )
-
-            return context.protocolResponse
-        } else {
-            logger.debug { "Validating checksum during deserialization from $checksumHeader" }
-
-            // Wrap the response body in a hashing body
-            return context.protocolResponse.copy(
-                body = context.protocolResponse.body
-                    .toHashingBody(checksumAlgorithm, context.protocolResponse.body.contentLength)
-                    .toChecksumValidatingBody(serviceChecksumValue),
-            )
-        }
+        // Wrap the response body in a hashing body
+        return context.protocolResponse.copy(
+            body = context.protocolResponse.body
+                .toHashingBody(checksumAlgorithm, context.protocolResponse.body.contentLength)
+                .toChecksumValidatingBody(serviceChecksumValue),
+        )
     }
 }