PR feedback checkpoint?

Author: 0marperez

codegen/smithy-kotlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/core/RuntimeTypes.kt

@@ -106,7 +106,6 @@ object RuntimeTypes {
         val TimestampFormat = symbol("TimestampFormat", "time")
         val ClientException = symbol("ClientException")
         val SdkDsl = symbol("SdkDsl")
-        val IllegalStateException = symbol("IllegalStateException")
 
         object BusinessMetrics : RuntimeTypePackage(KotlinDependency.CORE, "businessmetrics") {
             val AccountIdBasedEndpointAccountId = symbol("AccountIdBasedEndpointAccountId")
@@ -183,7 +182,6 @@ object RuntimeTypes {
         }
 
         object Text : RuntimeTypePackage(KotlinDependency.CORE, "text") {
-            val lowercase = symbol("lowercase")
             object Encoding : RuntimeTypePackage(KotlinDependency.CORE, "text.encoding") {
                 val decodeBase64 = symbol("decodeBase64")
                 val decodeBase64Bytes = symbol("decodeBase64Bytes")

runtime/protocol/http-client/common/src/aws/smithy/kotlin/runtime/http/interceptors/FlexibleChecksumsRequestInterceptor.kt

@@ -100,7 +100,7 @@ public class FlexibleChecksumsRequestInterceptor<I>(
         }
 
         if (checksumAlgorithm == null) {
-            logger.debug { "A checksum algorithm isn't selected and checksum calculation isn't required, skipping checksum calculation" }
+            logger.debug { "A checksum algorithm isn't selected or checksum calculation isn't required, skipping checksum calculation" }
             return context.protocolRequest
         }
 

runtime/protocol/http-client/common/src/aws/smithy/kotlin/runtime/http/interceptors/FlexibleChecksumsResponseInterceptor.kt

@@ -10,7 +10,7 @@ import aws.smithy.kotlin.runtime.InternalApi
 import aws.smithy.kotlin.runtime.client.ProtocolResponseInterceptorContext
 import aws.smithy.kotlin.runtime.client.config.HttpChecksumConfigOption
 import aws.smithy.kotlin.runtime.collections.AttributeKey
-import aws.smithy.kotlin.runtime.hashing.toHashFunction
+import aws.smithy.kotlin.runtime.hashing.toHashFunctionOrThrow
 import aws.smithy.kotlin.runtime.http.HttpBody
 import aws.smithy.kotlin.runtime.http.readAll
 import aws.smithy.kotlin.runtime.http.request.HttpRequest
@@ -81,7 +81,7 @@ public class FlexibleChecksumsResponseInterceptor<I>(
 
         val checksumAlgorithm = checksumHeader
             .removePrefix("x-amz-checksum-")
-            .toHashFunction() ?: throw ClientException("Could not parse checksum algorithm from header $checksumHeader")
+            .toHashFunctionOrThrow()
 
         when (val bodyType = context.protocolResponse.body) {
             is HttpBody.Bytes -> {
@@ -108,7 +108,7 @@ public class FlexibleChecksumsResponseInterceptor<I>(
                         .toChecksumValidatingBody(serviceChecksumValue),
                 )
             }
-            else -> throw IllegalStateException("Http body type '$bodyType' is not supported for flexible checksums.")
+            else -> throw IllegalStateException("HTTP body type '$bodyType' is not supported for flexible checksums.")
         }
     }
 }

runtime/runtime-core/api/runtime-core.api

@@ -21,10 +21,6 @@ public final class aws/smithy/kotlin/runtime/ErrorMetadata$Companion {
 public abstract interface annotation class aws/smithy/kotlin/runtime/ExperimentalApi : java/lang/annotation/Annotation {
 }
 
-public final class aws/smithy/kotlin/runtime/IllegalStateException : java/lang/IllegalStateException {
-	public fun <init> (Ljava/lang/String;)V
-}
-
 public abstract interface annotation class aws/smithy/kotlin/runtime/InternalApi : java/lang/annotation/Annotation {
 }
 
@@ -2088,7 +2084,6 @@ public final class aws/smithy/kotlin/runtime/text/Scanner {
 public final class aws/smithy/kotlin/runtime/text/TextKt {
 	public static final fun ensurePrefix (Ljava/lang/String;Ljava/lang/String;)Ljava/lang/String;
 	public static final fun ensureSuffix (Ljava/lang/String;Ljava/lang/String;)Ljava/lang/String;
-	public static final fun lowercase (Ljava/lang/String;)Ljava/lang/String;
 }
 
 public final class aws/smithy/kotlin/runtime/text/Utf8Kt {

runtime/runtime-core/common/src/aws/smithy/kotlin/runtime/Exceptions.kt

@@ -7,7 +7,6 @@ package aws.smithy.kotlin.runtime
 import aws.smithy.kotlin.runtime.collections.AttributeKey
 import aws.smithy.kotlin.runtime.collections.MutableAttributes
 import aws.smithy.kotlin.runtime.collections.mutableAttributes
-import kotlin.IllegalStateException
 
 /**
  * Additional metadata about an error
@@ -175,9 +174,3 @@ public open class ServiceException : SdkBaseException {
 
     override val sdkErrorMetadata: ServiceErrorMetadata = ServiceErrorMetadata()
 }
-
-/**
- * Runtime accessible version of the [IllegalStateException]
- */
-@InternalApi
-public class IllegalStateException(message: String) : IllegalStateException(message)

runtime/runtime-core/common/src/aws/smithy/kotlin/runtime/text/Text.kt

@@ -6,13 +6,9 @@
 package aws.smithy.kotlin.runtime.text
 
 import aws.smithy.kotlin.runtime.InternalApi
-import java.util.*
 
 @InternalApi
 public fun String.ensurePrefix(prefix: String): String = if (startsWith(prefix)) this else prefix + this
 
 @InternalApi
 public fun String.ensureSuffix(suffix: String): String = if (endsWith(suffix)) this else plus(suffix)
-
-@InternalApi
-public fun String.lowercase(): String = this.lowercase(Locale.getDefault())