Skip to content

Commit 189edc7

Browse files
committed
Revert @required removal
1 parent 04a33e9 commit 189edc7

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

codegen/protocol-tests/model/error-correction-tests.smithy

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@ operation SayHelloXml { output: TestOutput, errors: [Error] }
3939

4040
structure TestOutputDocument with [TestStruct] {
4141
innerField: Nested,
42-
@required
42+
43+
// Note: This shape _should_ be @required, but causes Smithy httpResponseTests validation to fail.
44+
// We expect `document` to be deserialized as `null` and enforce @required using a runtime check, but Smithy validator doesn't recognize / allow this.
4345
document: Document
4446
}
4547
structure TestOutput with [TestStruct] { innerField: Nested }
@@ -64,7 +66,8 @@ structure TestStruct {
6466
@required
6567
nestedListValue: NestedList
6668

67-
@required
69+
// Note: This shape _should_ be @required, but causes Smithy httpResponseTests validation to fail.
70+
// We expect `nested` to be deserialized as `null` and enforce @required using a runtime check, but Smithy validator doesn't recognize / allow this.
6871
nested: Nested
6972

7073
@required

0 commit comments

Comments
 (0)