Skip to content

Commit 1f271bf

Browse files
committed
Re-enable way more tests
1 parent ba7bfa4 commit 1f271bf

File tree

38 files changed

+4
-387
lines changed

38 files changed

+4
-387
lines changed

runtime/crt-util/jvmAndNative/test/aws/smithy/kotlin/runtime/crt/SdkSourceBodyStreamTest.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ class SdkSourceBodyStreamTest {
2222
return MutableBuffer.of(dest) to dest
2323
}
2424

25-
@IgnoreNative // FIXME Re-enable after Kotlin/Native implementation
2625
@Test
2726
fun testReadFully() = runTest {
2827
val data = byteArrayOf(1, 2, 3, 4, 5)
@@ -37,7 +36,6 @@ class SdkSourceBodyStreamTest {
3736
}
3837
}
3938

40-
@IgnoreNative // FIXME Re-enable after Kotlin/Native implementation
4139
@Test
4240
fun testPartialRead() = runTest {
4341
val source = "123456".encodeToByteArray().source()
@@ -55,7 +53,6 @@ class SdkSourceBodyStreamTest {
5553
assertEquals("456", sent2.decodeToString())
5654
}
5755

58-
@IgnoreNative // FIXME Re-enable after Kotlin/Native implementation
5956
@Test
6057
fun testLargeTransfer() = runTest {
6158
val data = "foobar"

runtime/protocol/aws-event-stream/common/test/aws/smithy/kotlin/runtime/awsprotocol/eventstream/FrameDecoderTest.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import kotlin.test.assertEquals
1515
import kotlin.test.assertFailsWith
1616

1717
class FrameDecoderTest {
18-
@IgnoreNative // FIXME Re-enable after Kotlin/Native implementation
1918
@Test
2019
fun testFrameStreamSingleMessage() = runTest {
2120
val encoded = validMessageWithAllHeaders()
@@ -29,7 +28,6 @@ class FrameDecoderTest {
2928
assertEquals(expected, actual.first())
3029
}
3130

32-
@IgnoreNative // FIXME Re-enable after Kotlin/Native implementation
3331
@Test
3432
fun testFrameStreamMultipleMessagesChunked() = runTest {
3533
val encoded = SdkBuffer().apply {
@@ -53,7 +51,6 @@ class FrameDecoderTest {
5351
assertEquals(expected3, actual[2])
5452
}
5553

56-
@IgnoreNative // FIXME Re-enable after Kotlin/Native implementation
5754
@Test
5855
fun testChannelClosed() = runTest {
5956
// contents don't matter

runtime/protocol/aws-json-protocols/common/test/aws/smithy/kotlin/runtime/awsprotocol/json/AwsJsonProtocolTest.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import kotlin.test.Test
1818
import kotlin.test.assertEquals
1919

2020
class AwsJsonProtocolTest {
21-
@IgnoreNative // FIXME Re-enable after Kotlin/Native implementation
2221
@Test
2322
fun testSetJsonProtocolHeaders() = runTest {
2423
@Suppress("DEPRECATION")
@@ -41,7 +40,6 @@ class AwsJsonProtocolTest {
4140
assertEquals("FooService_blah.Bar", request.headers["X-Amz-Target"])
4241
}
4342

44-
@IgnoreNative // FIXME Re-enable after Kotlin/Native implementation
4543
@Test
4644
fun testEmptyBody() = runTest {
4745
@Suppress("DEPRECATION")
@@ -61,7 +59,6 @@ class AwsJsonProtocolTest {
6159
assertEquals("{}", actual)
6260
}
6361

64-
@IgnoreNative // FIXME Re-enable after Kotlin/Native implementation
6562
@Test
6663
fun testDoesNotOverride() = runTest {
6764
@Suppress("DEPRECATION")

runtime/protocol/http-client-engines/http-client-engine-crt/jvmAndNative/test/aws/smithy/kotlin/runtime/http/engine/crt/AsyncStressTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class AsyncStressTest : TestWithLocalServer() {
3737
}
3838
}.start()
3939

40-
@IgnoreNative // FIXME Re-enable after Kotlin/Native implementation
40+
// @IgnoreNative // FIXME Re-enable after Kotlin/Native implementation
4141
@Test
4242
fun testStreamNotConsumed() = runBlocking {
4343
// test that filling the stream window and not consuming the body stream still cleans up resources

runtime/protocol/http-client-engines/http-client-engine-crt/jvmAndNative/test/aws/smithy/kotlin/runtime/http/engine/crt/RequestConversionTest.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ class RequestConversionTest {
5454
assertFalse(crtRequest.body is ReadChannelBodyStream)
5555
}
5656

57-
@IgnoreNative // FIXME Re-enable after Kotlin/Native implementation
5857
@Test
5958
fun testSdkToCrtRequestStreamingBody() {
6059
val stream = byteStreamFromContents("foobar")
@@ -73,7 +72,6 @@ class RequestConversionTest {
7372
crtBody.cancel()
7473
}
7574

76-
@IgnoreNative // FIXME Re-enable after Kotlin/Native implementation
7775
@Test
7876
fun testEngineAddsContentLengthHeader() {
7977
val stream = byteStreamFromContents("foobar")

runtime/protocol/http-client-engines/http-client-engine-crt/jvmAndNative/test/aws/smithy/kotlin/runtime/http/engine/crt/SdkStreamResponseHandlerTest.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,6 @@ class SdkStreamResponseHandlerTest {
125125
assertTrue(respChan.isClosedForWrite)
126126
}
127127

128-
@IgnoreNative // FIXME Re-enable after Kotlin/Native implementation
129128
@Test
130129
fun testRespBody() = runTest {
131130
val handler = SdkStreamResponseHandler(mockConn, coroutineContext)
@@ -154,7 +153,6 @@ class SdkStreamResponseHandlerTest {
154153
assertEquals(data, respChan.readToBuffer().readUtf8())
155154
}
156155

157-
@IgnoreNative // FIXME Re-enable after Kotlin/Native implementation
158156
@Test
159157
fun testStreamError() = runTest {
160158
val handler = SdkStreamResponseHandler(mockConn, coroutineContext)

runtime/protocol/http-client-engines/http-client-engine-crt/jvmAndNative/test/aws/smithy/kotlin/runtime/http/engine/crt/SendChunkedBodyTest.kt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ class SendChunkedBodyTest {
2828
}
2929
}
3030

31-
@IgnoreNative // FIXME Re-enable after Kotlin/Native implementation
3231
@Test
3332
fun testSourceContent() = runTest {
3433
val stream = MockHttpStream(200)
@@ -46,7 +45,6 @@ class SendChunkedBodyTest {
4645
assertEquals(1, stream.numChunksWritten)
4746
}
4847

49-
@IgnoreNative // FIXME Re-enable after Kotlin/Native implementation
5048
@Test
5149
fun testChannelContentMultipleChunks() = runTest {
5250
val stream = MockHttpStream(200)
@@ -68,7 +66,6 @@ class SendChunkedBodyTest {
6866
assertTrue(stream.numChunksWritten > 1)
6967
}
7068

71-
@IgnoreNative // FIXME Re-enable after Kotlin/Native implementation
7269
@Test
7370
fun testChannelContent() = runTest {
7471
val stream = MockHttpStream(200)
@@ -87,7 +84,6 @@ class SendChunkedBodyTest {
8784
assertEquals(1, stream.numChunksWritten)
8885
}
8986

90-
@IgnoreNative // FIXME Re-enable after Kotlin/Native implementation
9187
@Test
9288
fun testSourceContentMultipleChunks() = runTest {
9389
val stream = MockHttpStream(200)

runtime/protocol/http-client/common/test/aws/smithy/kotlin/runtime/http/engine/HttpCallContextTest.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import kotlin.test.assertTrue
2525
import kotlin.coroutines.coroutineContext as currentCoroutineContext
2626

2727
class HttpCallContextTest {
28-
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
2928
@OptIn(ExperimentalCoroutinesApi::class)
3029
@Test
3130
fun testStructuredConcurrency() = runTest {

runtime/protocol/http-client/common/test/aws/smithy/kotlin/runtime/http/engine/HttpClientEngineTest.kt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ class HttpClientEngineTest {
6161
private val HttpCall.job: Job
6262
get() = coroutineContext.job
6363

64-
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
6564
@Test
6665
fun testCallComplete() = runTest {
6766
val call = client.call(HttpRequestBuilder())
@@ -71,7 +70,6 @@ class HttpClientEngineTest {
7170
assertTrue(call.job.isCompleted)
7271
}
7372

74-
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
7573
@Test
7674
fun testUserContextCancelsRequestJob() = runTest {
7775
val job = launch {
@@ -88,7 +86,6 @@ class HttpClientEngineTest {
8886
assertTrue(callJob.isCancelled)
8987
}
9088

91-
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
9289
@Test
9390
fun testInFlightRequestJobsAreIndependent() = runTest {
9491
val job1 = launch {
@@ -113,7 +110,6 @@ class HttpClientEngineTest {
113110
job2.cancel()
114111
}
115112

116-
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
117113
@Test
118114
fun testEngineJobNotCancelledByRequestJobs() = runTest {
119115
launch {
@@ -131,7 +127,6 @@ class HttpClientEngineTest {
131127
assertTrue(engine.coroutineContext.job.isActive)
132128
}
133129

134-
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
135130
@Test
136131
fun testShutdownOnlyAfterInFlightDone() = runTest {
137132
val waiter = Channel<Unit>(1)
@@ -166,7 +161,6 @@ class HttpClientEngineTest {
166161
assertTrue(engine.shutdownCalled)
167162
}
168163

169-
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
170164
@Test
171165
fun testRequestAfterClose() = runTest {
172166
engine.close()

runtime/protocol/http-client/common/test/aws/smithy/kotlin/runtime/http/interceptors/CachingChecksumInterceptorTest.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ private val CHECKSUM_TEST_HEADER = "x-amz-kotlin-sdk-test-checksum-header"
2525
class CachingChecksumInterceptorTest {
2626
private val client = SdkHttpClient(TestEngine())
2727

28-
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
2928
@Test
3029
fun testChecksumIsCalculatedAndApplied() = runTest {
3130
val req = HttpRequestBuilder().apply {
@@ -42,7 +41,6 @@ class CachingChecksumInterceptorTest {
4241
assertEquals(expectedChecksumValue, call.request.headers[CHECKSUM_TEST_HEADER])
4342
}
4443

45-
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
4644
@Test
4745
fun testCachedChecksumIsUsed() = runTest {
4846
val req = HttpRequestBuilder().apply {

0 commit comments

Comments
 (0)