Remove lineSeparator from Filesystem, define as a public extension function of OperatingSystem

Author: lauzadis

runtime/runtime-core/api/runtime-core.api

@@ -2329,7 +2329,6 @@ public abstract interface class aws/smithy/kotlin/runtime/util/Filesystem {
 	public static final field Companion Laws/smithy/kotlin/runtime/util/Filesystem$Companion;
 	public abstract fun fileExists (Ljava/lang/String;)Z
 	public abstract fun getFilePathSeparator ()Ljava/lang/String;
-	public abstract fun getLineSeparator ()Ljava/lang/String;
 	public abstract fun readFileOrNull (Ljava/lang/String;Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
 	public abstract fun writeFile (Ljava/lang/String;[BLkotlin/coroutines/Continuation;)Ljava/lang/Object;
 }
@@ -2397,6 +2396,10 @@ public final class aws/smithy/kotlin/runtime/util/OsFamily : java/lang/Enum {
 public abstract interface class aws/smithy/kotlin/runtime/util/PlatformEnvironProvider : aws/smithy/kotlin/runtime/util/EnvironmentProvider, aws/smithy/kotlin/runtime/util/PropertyProvider {
 }
 
+public final class aws/smithy/kotlin/runtime/util/PlatformKt {
+	public static final fun getLineSeparator (Laws/smithy/kotlin/runtime/util/OperatingSystem;)Ljava/lang/String;
+}
+
 public abstract interface class aws/smithy/kotlin/runtime/util/PlatformProvider : aws/smithy/kotlin/runtime/util/Filesystem, aws/smithy/kotlin/runtime/util/PlatformEnvironProvider {
 	public static final field Companion Laws/smithy/kotlin/runtime/util/PlatformProvider$Companion;
 	public abstract fun isAndroid ()Z
@@ -2438,7 +2441,6 @@ public final class aws/smithy/kotlin/runtime/util/TestPlatformProvider : aws/smi
 	public fun getAllEnvVars ()Ljava/util/Map;
 	public fun getAllProperties ()Ljava/util/Map;
 	public fun getFilePathSeparator ()Ljava/lang/String;
-	public fun getLineSeparator ()Ljava/lang/String;
 	public fun getProperty (Ljava/lang/String;)Ljava/lang/String;
 	public fun getenv (Ljava/lang/String;)Ljava/lang/String;
 	public fun isAndroid ()Z

runtime/runtime-core/common/src/aws/smithy/kotlin/runtime/util/Filesystem.kt

@@ -16,12 +16,6 @@ public interface Filesystem {
      */
     public val filePathSeparator: String
 
-    /**
-     * The string which represents a line separator on this file system. For example, on Windows, this is CRLF.
-     */
-    public val lineSeparator: String
-        get() = "\n"
-
     /**
      * Read the contents of a file as a [String] or return null on any error.
      *

runtime/runtime-core/common/src/aws/smithy/kotlin/runtime/util/Platform.kt

@@ -36,7 +36,6 @@ public interface PlatformProvider :
 internal expect object SystemDefaultProvider : PlatformProvider {
     override fun osInfo(): OperatingSystem
     override val filePathSeparator: String
-    override val lineSeparator: String
     override fun fileExists(path: String): Boolean
     override fun getAllEnvVars(): Map<String, String>
     override fun getAllProperties(): Map<String, String>
@@ -51,14 +50,17 @@ internal expect object SystemDefaultProvider : PlatformProvider {
     override val isNative: Boolean
 }
 
-internal val OperatingSystem.lineSeparator: String
+public data class OperatingSystem(val family: OsFamily, val version: String?)
+
+/**
+ * The string which represents a line separator on this file system. For example, on Windows, this is CRLF.
+ */
+public val OperatingSystem.lineSeparator: String
     get() = when {
         family == OsFamily.Windows -> "\r\n"
         else -> "\n"
     }
 
-public data class OperatingSystem(val family: OsFamily, val version: String?)
-
 public enum class OsFamily {
     Linux,
     MacOs,

runtime/runtime-core/jvm/src/aws/smithy/kotlin/runtime/util/PlatformJVM.kt

@@ -71,8 +71,6 @@ internal actual object SystemDefaultProvider : PlatformProvider {
      * segment char is '/'.
      */
     actual override val filePathSeparator: String by lazy { File.separator }
-
-    actual override val lineSeparator: String by lazy { osInfo().lineSeparator }
 }
 
 private fun isAndroid(): Boolean = try {

runtime/runtime-core/native/src/aws/smithy/kotlin/runtime/util/PlatformNative.kt

@@ -16,9 +16,6 @@ internal actual object SystemDefaultProvider : PlatformProvider {
     actual override val filePathSeparator: String
         get() = TODO("Not yet implemented")
 
-    actual override val lineSeparator: String
-        get() = TODO("Not yet implemented")
-
     actual override suspend fun readFileOrNull(path: String): ByteArray? {
         TODO("Not yet implemented")
     }