address pr reviews

Author: xinsong-cui

codegen/smithy-aws-kotlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/aws/customization/RegionSupport.kt

@@ -43,6 +43,19 @@ class RegionSupport : KotlinIntegration {
                 The region to sign with and make requests to.
             """.trimIndent()
         }
+
+        val RegionProviderProp: ConfigProperty = ConfigProperty {
+            name = "regionProvider"
+            symbol = RuntimeTypes.SmithyClient.Region.RegionProvider.asNullable()
+            documentation = """
+              An optional region provider that determines the AWS region for client operations. When specified, this provider
+              takes precedence over the default region provider chain, unless a static region is explicitly configured.
+              The region resolution order is:
+              1. Static region (if specified)
+              2. Custom region provider (if configured)
+              3. Default region provider chain
+            """.trimIndent()
+        }
     }
 
     // Allow other integrations to customize the service config props, later integrations take precedence.
@@ -57,8 +70,10 @@ class RegionSupport : KotlinIntegration {
         return supportsSigv4 || hasRegionBuiltin || isAwsSdk
     }
 
-    override fun additionalServiceConfigProps(ctx: CodegenContext): List<ConfigProperty> = listOf(RegionProp)
-
+    override fun additionalServiceConfigProps(ctx: CodegenContext): List<ConfigProperty> = buildList {
+        add(RegionProp)
+        add(RegionProviderProp)
+    }
     override fun customizeEndpointResolution(ctx: ProtocolGenerator.GenerationContext): EndpointCustomization =
         object : EndpointCustomization {
             override fun renderBindEndpointBuiltins(

codegen/smithy-kotlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/core/KotlinDependency.kt

@@ -38,7 +38,6 @@ private fun getDefaultRuntimeVersion(): String {
 const val RUNTIME_GROUP: String = "aws.smithy.kotlin"
 val RUNTIME_VERSION: String = System.getProperty("smithy.kotlin.codegen.clientRuntimeVersion", getDefaultRuntimeVersion())
 val KOTLIN_COMPILER_VERSION: String = System.getProperty("smithy.kotlin.codegen.kotlinCompilerVersion", "2.0.10")
-val KOTLINX_COROUTINES_VERSION: String = System.getProperty("smithy.kotlin.codegen.kotlinCoroutinesVersion", "1.9.0")
 
 enum class SourceSet {
     CommonMain,
@@ -135,7 +134,6 @@ data class KotlinDependency(
         // External third-party dependencies
         val KOTLIN_STDLIB = KotlinDependency(GradleConfiguration.Implementation, "kotlin", "org.jetbrains.kotlin", "kotlin-stdlib", KOTLIN_COMPILER_VERSION)
         val KOTLIN_TEST = KotlinDependency(GradleConfiguration.TestImplementation, "kotlin.test", "org.jetbrains.kotlin", "kotlin-test", KOTLIN_COMPILER_VERSION)
-        val KOTLINX_COROUTINES = KotlinDependency(GradleConfiguration.Implementation, "kotlinx.coroutines", "org.jetbrains.kotlinx", "kotlinx-coroutines-core", KOTLINX_COROUTINES_VERSION)
     }
 
     override fun getDependencies(): List<SymbolDependency> {

codegen/smithy-kotlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/core/RuntimeTypes.kt

@@ -247,6 +247,10 @@ object RuntimeTypes {
                 val Url = symbol("Url")
             }
         }
+
+        object Region : RuntimeTypePackage(KotlinDependency.SMITHY_CLIENT, "region") {
+            val RegionProvider = symbol("RegionProvider")
+        }
     }
 
     object Serde : RuntimeTypePackage(KotlinDependency.SERDE) {
@@ -409,6 +413,7 @@ object RuntimeTypes {
 
         val CompletableDeferred = "kotlinx.coroutines.CompletableDeferred".toSymbol()
         val job = "kotlinx.coroutines.job".toSymbol()
+        val runBlocking = "kotlinx.coroutines.runBlocking".toSymbol()
 
         object Flow {
             // NOTE: smithy-kotlin core has an API dependency on this already

codegen/smithy-kotlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/lang/KotlinTypes.kt

@@ -118,8 +118,7 @@ object KotlinTypes {
         val minutes = stdlibSymbol("minutes", "time.Duration.Companion")
     }
 
-    object Coroutines : RuntimeTypePackage(KotlinDependency.KOTLINX_COROUTINES) {
-        val runBlocking = symbol("runBlocking")
+    object Coroutines {
         val CoroutineContext = "kotlin.coroutines.CoroutineContext".toSymbol()
     }
 

runtime/smithy-client/api/smithy-client.api

@@ -325,3 +325,7 @@ public final class aws/smithy/kotlin/runtime/client/endpoints/functions/Url {
 	public fun toString ()Ljava/lang/String;
 }
 
+public abstract interface class aws/smithy/kotlin/runtime/client/region/RegionProvider {
+	public abstract fun getRegion (Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
+}
+

runtime/smithy-client/common/src/aws/smithy/kotlin/runtime/client/region/RegionProvider.kt

@@ -0,0 +1,17 @@
+/*
+ * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+package aws.smithy.kotlin.runtime.client.region
+
+/**
+ * Interface for providing AWS region information. Implementations are free to use any strategy for
+ * providing region information
+ */
+public interface RegionProvider {
+    /**
+     * Return the region name to use. If region information is not available, implementations should return null
+     */
+    public suspend fun getRegion(): String?
+}