Skip to content

Commit 49a0089

Browse files
authored
chore: upgrade to published version (#1021)
1 parent 3776f5b commit 49a0089

File tree

3 files changed

+20
-22
lines changed

3 files changed

+20
-22
lines changed

build.gradle.kts

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,6 @@ buildscript {
1111
// only need to add e.g. atomic-fu and build-plugins here for imports and plugins to be available in subprojects.
1212
dependencies {
1313
classpath(libs.kotlinx.atomicfu.plugin)
14-
15-
// Add our custom gradle plugin(s) to buildscript classpath (comes from github source)
16-
// NOTE: Anything included in our build plugin is added to the classpath for all projects,
17-
// this includes bundled plugins and their versions. As an example the smithy gradle base
18-
// plugin is used by the smithybuild plugin which means you can't apply it with a different
19-
// version directly because it's already on the classpath.
20-
// FIXME - if we publish this plugin it would fix a lot of things
21-
classpath("aws.sdk.kotlin:build-plugins") {
22-
version {
23-
require("0.3.2")
24-
}
25-
}
2614
}
2715
}
2816

@@ -33,10 +21,16 @@ plugins {
3321
// since build-plugins also has <some> version in its dependency closure
3422
alias(libs.plugins.kotlin.multiplatform) apply false
3523
alias(libs.plugins.kotlin.jvm) apply false
36-
}
3724

38-
// configures (KMP) subprojects with our own KMP conventions and some default dependencies
39-
apply(plugin = "aws.sdk.kotlin.kmp")
25+
// Add our custom gradle plugin(s) to buildscript classpath
26+
// NOTE: Anything included in our build plugin is added to the classpath for all projects,
27+
// this includes bundled plugins and their versions. As an example the smithy gradle base
28+
// plugin is used by the smithybuild plugin which means you can't apply it with a different
29+
// version directly because it's already on the classpath.
30+
//
31+
// Plugin configures (KMP) subprojects with our own KMP conventions and some default dependencies
32+
alias(libs.plugins.aws.kotlin.repo.tools.kmp)
33+
}
4034

4135
val testJavaVersion = typedProp<String>("test.java.version")?.let {
4236
JavaLanguageVersion.of(it)

gradle/libs.versions.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
kotlin-version = "1.9.21"
33
dokka-version = "1.9.10"
44

5+
aws-kotlin-repo-tools-version = "0.3.2"
6+
57
# libs
68
coroutines-version = "1.7.3"
79
atomicfu-version = "0.23.1"
@@ -93,3 +95,5 @@ kotlin-multiplatform = {id = "org.jetbrains.kotlin.multiplatform", version.ref =
9395
kotlinx-benchmark = { id = "org.jetbrains.kotlinx.benchmark", version.ref = "kotlinx-benchmark-version" }
9496
kotlinx-binary-compatibility-validator = { id = "org.jetbrains.kotlinx.binary-compatibility-validator", version = "0.13.2" }
9597
kotlinx-serialization = { id = "org.jetbrains.kotlin.plugin.serialization", version.ref = "kotlin-version"}
98+
aws-kotlin-repo-tools-kmp = { id = "aws.sdk.kotlin.kmp", version.ref = "aws-kotlin-repo-tools-version" }
99+
aws-kotlin-repo-tools-smithybuild = { id = "aws.sdk.kotlin.gradle.smithybuild", version.ref = "aws-kotlin-repo-tools-version" }

settings.gradle.kts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,13 @@ pluginManagement {
88
mavenLocal()
99
mavenCentral()
1010
gradlePluginPortal()
11+
maven {
12+
name = "kotlinRepoTools"
13+
url = java.net.URI("https://d2gys1nrxnjnyg.cloudfront.net/releases")
14+
content {
15+
includeGroupByRegex("""aws\.sdk\.kotlin.*""")
16+
}
17+
}
1118
}
1219
}
1320

@@ -19,13 +26,6 @@ dependencyResolutionManagement {
1926
}
2027
}
2128

22-
sourceControl {
23-
gitRepository(java.net.URI("https://github.com/awslabs/aws-kotlin-repo-tools.git")) {
24-
producesModule("aws.sdk.kotlin:build-plugins")
25-
producesModule("aws.sdk.kotlin:ktlint-rules")
26-
}
27-
}
28-
2929
rootProject.name = "smithy-kotlin"
3030

3131
include(":dokka-smithy")

0 commit comments

Comments
 (0)