chore: fix warnings (#499)

Author: ianbotsf

.github/workflows/continuous-integration.yml

@@ -34,6 +34,7 @@ jobs:
       run: |
         python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder.pyz')"
         chmod a+x builder.pyz
+        echo "kotlinWarningsAsErrors=true" >> $GITHUB_WORKSPACE/local.properties
         ./builder.pyz build -p ${{ env.PACKAGE_NAME }}
 
   macos-compat:
@@ -53,6 +54,7 @@ jobs:
       run: |
         python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder.pyz')"
         chmod a+x builder.pyz
+        echo "kotlinWarningsAsErrors=true" >> $GITHUB_WORKSPACE/local.properties
         ./builder.pyz build -p ${{ env.PACKAGE_NAME }}
 
   windows-compat:
@@ -82,4 +84,5 @@ jobs:
       run: |
         python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder')"
         chmod a+x builder
+        echo "kotlinWarningsAsErrors=true" >> $GITHUB_WORKSPACE/local.properties
         ./builder build -p ${{ env.PACKAGE_NAME }} --spec downstream

benchmarks/serde-benchmarks/build.gradle.kts

@@ -27,7 +27,7 @@ platforms.forEach { platform ->
     apply(from = rootProject.file("gradle/${platform}.gradle"))
 }
 
-val experimentalAnnotations = listOf("kotlin.RequiresOptIn", "aws.smithy.kotlin.runtime.util.InternalApi")
+val optinAnnotations = listOf("kotlin.RequiresOptIn", "aws.smithy.kotlin.runtime.util.InternalApi")
 
 kotlin {
     sourceSets {
@@ -39,7 +39,7 @@ kotlin {
             kotlin.srcDir("$platform/$srcDir")
             resources.srcDir("$platform/${resourcesPrefix}resources")
             languageSettings.progressiveMode = true
-            experimentalAnnotations.forEach { languageSettings.optIn(it) }
+            optinAnnotations.forEach { languageSettings.optIn(it) }
         }
 
         val kotlinxBenchmarkVersion: String by project

build.gradle.kts

@@ -2,6 +2,8 @@
  * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
  * SPDX-License-Identifier: Apache-2.0.
  */
+import java.util.Properties
+
 buildscript {
     repositories {
         mavenCentral()
@@ -29,7 +31,25 @@ allprojects {
     }
 }
 
-if (project.properties["kotlinWarningsAsErrors"]?.toString()?.toBoolean() == true) {
+val localProperties: Map<String, Any> by lazy {
+    val props = Properties()
+
+    listOf(
+        File(rootProject.projectDir, "local.properties"), // Project-specific local properties
+        File(rootProject.projectDir.parent, "local.properties"), // Workspace-specific local properties
+        File(System.getProperty("user.home"), ".sdkdev/local.properties"), // User-specific local properties
+    )
+        .filter(File::exists)
+        .map(File::inputStream)
+        .forEach(props::load)
+
+    props.mapKeys { (k, _) -> k.toString() }
+}
+
+fun Project.prop(name: String): Any? =
+    this.properties[name] ?: localProperties[name]
+
+if (project.prop("kotlinWarningsAsErrors")?.toString()?.toBoolean() == true) {
     subprojects {
         tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {
             kotlinOptions.allWarningsAsErrors = true

runtime/build.gradle.kts

@@ -13,7 +13,7 @@ val platforms = listOf("common", "jvm", "android")
 
 // Allow subprojects to use internal API's
 // See: https://kotlinlang.org/docs/reference/opt-in-requirements.html#opting-in-to-using-api
-val experimentalAnnotations = listOf("kotlin.RequiresOptIn", "aws.smithy.kotlin.runtime.util.InternalApi")
+val optinAnnotations = listOf("kotlin.RequiresOptIn")
 
 fun projectNeedsPlatform(project: Project, platform: String ): Boolean {
     val files = project.projectDir.listFiles()
@@ -77,7 +77,7 @@ subprojects {
                 kotlin.srcDir("$platform/$srcDir")
                 resources.srcDir("$platform/${resourcesPrefix}resources")
                 languageSettings.progressiveMode = true
-                experimentalAnnotations.forEach { languageSettings.optIn(it) }
+                optinAnnotations.forEach { languageSettings.optIn(it) }
             }
         }
     }
@@ -106,4 +106,3 @@ task<org.jetbrains.kotlin.gradle.testing.internal.KotlinTestReport>("rootAllTest
         }
     }
 }
-

runtime/io/build.gradle.kts

@@ -34,5 +34,9 @@ kotlin {
                 implementation("io.ktor:ktor-utils:$ktorVersion")
             }
         }
+
+        all {
+            languageSettings.optIn("aws.smithy.kotlin.runtime.util.InternalApi")
+        }
     }
 }

runtime/logging/build.gradle.kts

@@ -18,5 +18,9 @@ kotlin {
                 implementation("io.github.microutils:kotlin-logging:$kotlinLoggingVersion")
             }
         }
+
+        all {
+            languageSettings.optIn("aws.smithy.kotlin.runtime.util.InternalApi")
+        }
     }
 }

runtime/protocol/http-client-engines/http-client-engine-ktor/build.gradle.kts

@@ -20,5 +20,9 @@ kotlin {
                 implementation(project(":runtime:logging"))
             }
         }
+
+        all {
+            languageSettings.optIn("aws.smithy.kotlin.runtime.util.InternalApi")
+        }
     }
 }

runtime/protocol/http-test/build.gradle.kts

@@ -31,5 +31,9 @@ kotlin {
                 api("io.ktor:ktor-server-cio:$ktorVersion")
             }
         }
+
+        all {
+            languageSettings.optIn("aws.smithy.kotlin.runtime.util.InternalApi")
+        }
     }
 }

runtime/protocol/http/build.gradle.kts

@@ -32,5 +32,9 @@ kotlin {
                 implementation(project(":runtime:testing"))
             }
         }
+
+        all {
+            languageSettings.optIn("aws.smithy.kotlin.runtime.util.InternalApi")
+        }
     }
 }

runtime/runtime-core/build.gradle.kts

@@ -36,5 +36,9 @@ kotlin {
                 implementation("com.charleskorn.kaml:kaml:$kamlVersion")
             }
         }
+
+        all {
+            languageSettings.optIn("aws.smithy.kotlin.runtime.util.InternalApi")
+        }
     }
 }