Skip to content

Commit 5ad9d5e

Browse files
committed
Update FIXME message
1 parent ed5da6b commit 5ad9d5e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

runtime/auth/http-auth-aws/common/test/aws/smithy/kotlin/runtime/http/auth/AwsHttpSignerTestBase.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ public abstract class AwsHttpSignerTestBase(
147147
assertEquals(expectedSig, signed.headers["Authorization"])
148148
}
149149

150-
@IgnoreNative // FIXME Native signed request has additional `transfer-encoding` header
150+
@IgnoreNative // FIXME Our JVM implementation does not sign `transfer-encoding`, but CRT does, causing a signature mismatch. Upgrade to latest version of aws-c-auth to get the fix.
151151
@Test
152152
public fun testSignAwsChunkedStreamNonReplayable(): TestResult = runTest {
153153
val op = buildOperation(streaming = true, replayable = false, requestBody = "a".repeat(AWS_CHUNKED_THRESHOLD + 1))
@@ -161,7 +161,7 @@ public abstract class AwsHttpSignerTestBase(
161161
assertEquals(expectedSig, signed.headers["Authorization"])
162162
}
163163

164-
@IgnoreNative // FIXME Native signed request has additional `transfer-encoding` header
164+
@IgnoreNative // FIXME Our JVM implementation does not sign `transfer-encoding`, but CRT does, causing a signature mismatch. Upgrade to latest version of aws-c-auth to get the fix.
165165
@Test
166166
public fun testSignAwsChunkedStreamReplayable(): TestResult = runTest {
167167
val op = buildOperation(streaming = true, replayable = true, requestBody = "a".repeat(AWS_CHUNKED_THRESHOLD + 1))
@@ -175,7 +175,7 @@ public abstract class AwsHttpSignerTestBase(
175175
assertEquals(expectedSig, signed.headers["Authorization"])
176176
}
177177

178-
@IgnoreNative // FIXME Native signed request has additional `transfer-encoding` header
178+
@IgnoreNative // FIXME Our JVM implementation does not sign `transfer-encoding`, but CRT does, causing a signature mismatch. Upgrade to latest version of aws-c-auth to get the fix.
179179
@Test
180180
public fun testSignOneShotStream(): TestResult = runTest {
181181
val op = buildOperation(streaming = true, replayable = false)

0 commit comments

Comments
 (0)