address pr reviews

Author: xinsong-cui

runtime/auth/aws-signing-default/api/aws-signing-default.api

@@ -1,11 +1,12 @@
 public final class aws/smithy/kotlin/runtime/auth/awssigning/DefaultAwsSignerBuilder {
 	public fun <init> ()V
 	public final fun build ()Laws/smithy/kotlin/runtime/auth/awssigning/AwsSigner;
-	public final fun withTelemetryProvider (Laws/smithy/kotlin/runtime/telemetry/TelemetryProvider;)Laws/smithy/kotlin/runtime/auth/awssigning/DefaultAwsSignerBuilder;
+	public final fun getTelemetryProvider ()Laws/smithy/kotlin/runtime/telemetry/TelemetryProvider;
+	public final fun setTelemetryProvider (Laws/smithy/kotlin/runtime/telemetry/TelemetryProvider;)V
 }
 
 public final class aws/smithy/kotlin/runtime/auth/awssigning/DefaultAwsSignerKt {
-	public static final fun defaultAwsSigner (Lkotlin/jvm/functions/Function1;)Laws/smithy/kotlin/runtime/auth/awssigning/AwsSigner;
+	public static final fun DefaultAwsSigner (Lkotlin/jvm/functions/Function1;)Laws/smithy/kotlin/runtime/auth/awssigning/AwsSigner;
 	public static final fun getDefaultAwsSigner ()Laws/smithy/kotlin/runtime/auth/awssigning/AwsSigner;
 }
 

runtime/auth/aws-signing-default/common/src/aws/smithy/kotlin/runtime/auth/awssigning/DefaultAwsSigner.kt

@@ -15,17 +15,14 @@ import kotlin.coroutines.coroutineContext
 /** The default implementation of [AwsSigner] */
 public val DefaultAwsSigner: AwsSigner = DefaultAwsSignerImpl()
 
-public fun defaultAwsSigner(block: DefaultAwsSignerBuilder.() -> Unit): AwsSigner = DefaultAwsSignerBuilder().apply(block).build()
+/** Creates a customized instance of [AwsSigner] */
+@Suppress("ktlint:standard:function-naming")
+public fun DefaultAwsSigner(block: DefaultAwsSignerBuilder.() -> Unit): AwsSigner =
+    DefaultAwsSignerBuilder().apply(block).build()
 
-/**
- * Builder class allows customers to configure telemetry provider for observability when using the signer as a standalone component.
- **/
+/** A builder class for creating instances of [AwsSigner] using the default implementation */
 public class DefaultAwsSignerBuilder {
-    private var telemetryProvider: TelemetryProvider? = null
-
-    public fun withTelemetryProvider(provider: TelemetryProvider): DefaultAwsSignerBuilder = apply {
-        this.telemetryProvider = provider
-    }
+    public var telemetryProvider: TelemetryProvider? = null
 
     public fun build(): AwsSigner = DefaultAwsSignerImpl(
         telemetryProvider = telemetryProvider,