Skip to content

Commit 85bf761

Browse files
committed
Fix serialization of blob shapes
1 parent 33b571f commit 85bf761

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

codegen/smithy-kotlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/rendering/serde/SerializeStructGenerator.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -647,7 +647,6 @@ open class SerializeStructGenerator(
647647
val target = member.targetOrSelf(ctx.model)
648648

649649
val encoded = when {
650-
target.type == ShapeType.BLOB -> writer.format("#L.#T()", identifier, RuntimeTypes.Core.Text.Encoding.encodeBase64String)
651650
target.type == ShapeType.TIMESTAMP -> {
652651
writer.addImport(RuntimeTypes.Core.TimestampFormat)
653652
val tsFormat = member

codegen/smithy-kotlin-codegen/src/test/kotlin/software/amazon/smithy/kotlin/codegen/rendering/serde/SerializeStructGeneratorTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1822,7 +1822,7 @@ class SerializeStructGeneratorTest {
18221822

18231823
val expected = """
18241824
serializer.serializeStruct(OBJ_DESCRIPTOR) {
1825-
input.fooBlob?.let { field(FOOBLOB_DESCRIPTOR, it.encodeBase64String()) }
1825+
input.fooBlob?.let { field(FOOBLOB_DESCRIPTOR, it) }
18261826
}
18271827
""".trimIndent()
18281828

runtime/serde/serde-xml/common/src/aws/smithy/kotlin/runtime/serde/xml/XmlSerializer.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ public class XmlSerializer(private val xmlWriter: XmlStreamWriter = xmlStreamWri
134134
field(descriptor, value.format(format))
135135

136136
override fun field(descriptor: SdkFieldDescriptor, value: ByteArray): Unit =
137-
field(descriptor, value)
137+
field(descriptor, value.encodeBase64String())
138138

139139
override fun field(descriptor: SdkFieldDescriptor, value: Document?): Unit = throw SerializationException(
140140
"cannot serialize field ${descriptor.serialName}; Document type is not supported by xml encoding",

0 commit comments

Comments
 (0)