Skip to content

Commit a7e2c7e

Browse files
committed
Remove breaking changes
1 parent 598b715 commit a7e2c7e

File tree

2 files changed

+36
-25
lines changed

2 files changed

+36
-25
lines changed

runtime/runtime-core/api/runtime-core.api

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,14 +82,14 @@ public abstract interface class aws/smithy/kotlin/runtime/businessmetrics/Busine
8282
}
8383

8484
public final class aws/smithy/kotlin/runtime/businessmetrics/BusinessMetricsUtilsKt {
85-
public static final fun containsBusinessMetric (Laws/smithy/kotlin/runtime/collections/Attributes;Laws/smithy/kotlin/runtime/businessmetrics/BusinessMetric;)Z
86-
public static final fun emitBusinessMetric (Laws/smithy/kotlin/runtime/collections/MutableAttributes;Laws/smithy/kotlin/runtime/businessmetrics/BusinessMetric;)V
85+
public static final fun containsBusinessMetric (Laws/smithy/kotlin/runtime/operation/ExecutionContext;Laws/smithy/kotlin/runtime/businessmetrics/BusinessMetric;)Z
8786
public static final fun emitBusinessMetric (Laws/smithy/kotlin/runtime/collections/MutableAttributes;Ljava/lang/String;)V
88-
public static final fun emitBusinessMetrics (Laws/smithy/kotlin/runtime/collections/MutableAttributes;Ljava/util/Set;)V
87+
public static final fun emitBusinessMetric (Laws/smithy/kotlin/runtime/operation/ExecutionContext;Laws/smithy/kotlin/runtime/businessmetrics/BusinessMetric;)V
88+
public static final fun emitBusinessMetric (Laws/smithy/kotlin/runtime/operation/ExecutionContext;Ljava/lang/String;)V
8989
public static final fun getAccountIdBasedEndpointAccountId ()Laws/smithy/kotlin/runtime/collections/AttributeKey;
9090
public static final fun getBusinessMetrics ()Laws/smithy/kotlin/runtime/collections/AttributeKey;
9191
public static final fun getServiceEndpointOverride ()Laws/smithy/kotlin/runtime/collections/AttributeKey;
92-
public static final fun removeBusinessMetric (Laws/smithy/kotlin/runtime/collections/MutableAttributes;Laws/smithy/kotlin/runtime/businessmetrics/BusinessMetric;)V
92+
public static final fun removeBusinessMetric (Laws/smithy/kotlin/runtime/operation/ExecutionContext;Laws/smithy/kotlin/runtime/businessmetrics/BusinessMetric;)V
9393
}
9494

9595
public final class aws/smithy/kotlin/runtime/businessmetrics/SmithyBusinessMetric : java/lang/Enum, aws/smithy/kotlin/runtime/businessmetrics/BusinessMetric {

runtime/runtime-core/common/src/aws/smithy/kotlin/runtime/businessmetrics/BusinessMetricsUtils.kt

Lines changed: 32 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,10 @@
55
package aws.smithy.kotlin.runtime.businessmetrics
66

77
import aws.smithy.kotlin.runtime.InternalApi
8-
import aws.smithy.kotlin.runtime.collections.*
8+
import aws.smithy.kotlin.runtime.collections.AttributeKey
9+
import aws.smithy.kotlin.runtime.collections.MutableAttributes
10+
import aws.smithy.kotlin.runtime.collections.get
11+
import aws.smithy.kotlin.runtime.operation.ExecutionContext
912

1013
/**
1114
* Keeps track of all business metrics along an operations execution
@@ -26,49 +29,57 @@ public val AccountIdBasedEndpointAccountId: AttributeKey<String> = AttributeKey(
2629
public val ServiceEndpointOverride: AttributeKey<Boolean> = AttributeKey("aws.smithy.kotlin#ServiceEndpointOverride")
2730

2831
/**
29-
* Emits a business metric into [MutableAttributes]
30-
* @param identifier The identifier of the [BusinessMetric] to be emitted.
32+
* Emit a business metric to the execution context attributes
3133
*/
3234
@InternalApi
33-
public fun MutableAttributes.emitBusinessMetric(identifier: String) {
34-
if (this.contains(BusinessMetrics)) {
35-
this[BusinessMetrics].add(identifier)
35+
public fun ExecutionContext.emitBusinessMetric(metric: BusinessMetric) {
36+
if (this.attributes.contains(BusinessMetrics)) {
37+
this.attributes[BusinessMetrics].add(metric.identifier)
3638
} else {
37-
this[BusinessMetrics] = mutableSetOf(identifier)
39+
this.attributes[BusinessMetrics] = mutableSetOf(metric.identifier)
3840
}
3941
}
4042

4143
/**
42-
* Emits a business metric into [MutableAttributes]
43-
* @param metric The [BusinessMetric] to be emitted.
44+
* Emit a business metric to the execution context attributes using its identifier
4445
*/
4546
@InternalApi
46-
public fun MutableAttributes.emitBusinessMetric(metric: BusinessMetric): Unit = this.emitBusinessMetric(metric.identifier)
47+
public fun ExecutionContext.emitBusinessMetric(identifier: String) {
48+
if (this.attributes.contains(BusinessMetrics)) {
49+
this.attributes[BusinessMetrics].add(identifier)
50+
} else {
51+
this.attributes[BusinessMetrics] = mutableSetOf(identifier)
52+
}
53+
}
4754

4855
/**
49-
* Emits business metrics into [MutableAttributes]
50-
* @param metrics The [BusinessMetric]s to be emitted.
56+
* Emit a business metric to the mutable attributes
5157
*/
5258
@InternalApi
53-
public fun MutableAttributes.emitBusinessMetrics(metrics: Set<BusinessMetric>): Unit =
54-
metrics.forEach { emitBusinessMetric(it) }
59+
public fun MutableAttributes.emitBusinessMetric(identifier: String) {
60+
if (this.contains(BusinessMetrics)) {
61+
this[BusinessMetrics].add(identifier)
62+
} else {
63+
this[BusinessMetrics] = mutableSetOf(identifier)
64+
}
65+
}
5566

5667
/**
57-
* Removes a business metric from the [MutableAttributes]
68+
* Removes a business metric from the execution context attributes
5869
*/
5970
@InternalApi
60-
public fun MutableAttributes.removeBusinessMetric(metric: BusinessMetric) {
61-
if (this.contains(BusinessMetrics)) {
62-
this[BusinessMetrics].remove(metric.identifier)
71+
public fun ExecutionContext.removeBusinessMetric(metric: BusinessMetric) {
72+
if (this.attributes.contains(BusinessMetrics)) {
73+
this.attributes[BusinessMetrics].remove(metric.identifier)
6374
}
6475
}
6576

6677
/**
67-
* Checks if a business metric exists in the [Attributes]
78+
* Checks if a business metric exists in the execution context attributes
6879
*/
6980
@InternalApi
70-
public fun Attributes.containsBusinessMetric(metric: BusinessMetric): Boolean =
71-
(this.contains(BusinessMetrics)) && this[BusinessMetrics].contains(metric.identifier)
81+
public fun ExecutionContext.containsBusinessMetric(metric: BusinessMetric): Boolean =
82+
(this.attributes.contains(BusinessMetrics)) && this.attributes[BusinessMetrics].contains(metric.identifier)
7283

7384
/**
7485
* Valid business metrics

0 commit comments

Comments
 (0)