misc: enable allWarningsAsErrors (#1395)

Author: lauzadis

build.gradle.kts

@@ -5,6 +5,7 @@
 import aws.sdk.kotlin.gradle.dsl.configureJReleaser
 import aws.sdk.kotlin.gradle.dsl.configureLinting
 import aws.sdk.kotlin.gradle.util.typedProp
+import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
 
 buildscript {
     // NOTE: buildscript classpath for the root project is the parent classloader for the subprojects, we
@@ -46,9 +47,9 @@ val testJavaVersion = typedProp<String>("test.java.version")?.let {
 }
 
 allprojects {
-    if (rootProject.typedProp<Boolean>("kotlinWarningsAsErrors") == true) {
-        tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {
-            compilerOptions.allWarningsAsErrors = true
+    tasks.withType<KotlinCompile> {
+        compilerOptions {
+            allWarningsAsErrors = true
         }
     }
 

codegen/smithy-kotlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/rendering/waiters/KotlinJmespathExpressionVisitor.kt

@@ -164,6 +164,7 @@ class KotlinJmespathExpressionVisitor(
 
         val codegen = buildString {
             val nullables = buildList {
+                // FIXME In some cases we are unnecessarily handling nulls here, leading to compiler warnings. SDK-KT-786
                 if (left.shape?.isNullable == true || left.nullable) add("${left.identifier} == null")
                 if (right.shape?.isNullable == true || right.nullable) add("${right.identifier} == null")
             }

dokka-smithy/build.gradle.kts

@@ -35,7 +35,6 @@ tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {
     compilerOptions {
         jvmTarget.set(JvmTarget.JVM_1_8)
         freeCompilerArgs.add("-Xjdk-release=1.8")
-        allWarningsAsErrors.set(false) // FIXME Dokka bundles stdlib into the classpath, causing an unfixable warning
     }
 }
 

runtime/runtime-core/jvm/test/aws/smithy/kotlin/runtime/io/SdkByteChannelStressTest.kt

@@ -95,7 +95,7 @@ class SdkByteChannelStressTest {
     }
 
     @Test
-    fun testReadAllFromFailedChannel() = runBlocking {
+    fun testReadAllFromFailedChannel(): Unit = runBlocking {
         val ch = SdkByteChannel(true)
         ch.cancel(TestException())
         assertFailsWith<TestException> {

tests/codegen/nullability-tests/build.gradle.kts

@@ -45,8 +45,6 @@ kotlin.sourceSets.getByName("main") {
 
 tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {
     dependsOn(tasks.generateSmithyProjections)
-    // FIXME - generated code has warnings unfortunately, see https://github.com/awslabs/aws-sdk-kotlin/issues/1169
-    compilerOptions.allWarningsAsErrors = false
 }
 
 tasks.test {

tests/codegen/serde-tests/build.gradle.kts

@@ -96,8 +96,6 @@ kotlin.sourceSets.getByName("main") {
 
 tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {
     dependsOn(stageGeneratedSources)
-    // generated code has warnings unfortunately, see https://github.com/awslabs/aws-sdk-kotlin/issues/1169
-    compilerOptions.allWarningsAsErrors = false
 }
 
 tasks.clean.configure {

tests/codegen/waiter-tests/build.gradle.kts

@@ -38,8 +38,8 @@ kotlin.sourceSets.getByName("main") {
 
 tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {
     dependsOn(tasks.generateSmithyProjections)
+    // FIXME Re-enable warnings as errors SDK-KT-785
     compilerOptions {
-        // generated code has warnings unfortunately
         allWarningsAsErrors = false
     }
 }