chore: re-enable K/N ignored tests

Author: ianbotsf

gradle/libs.versions.toml

@@ -13,7 +13,7 @@ okio-version = "3.16.0"
 otel-version = "1.52.0"
 slf4j-version = "2.0.17"
 slf4j-v1x-version = "1.7.36"
-crt-kotlin-version = "0.11.5"
+crt-kotlin-version = "0.11.6"
 micrometer-version = "1.15.2"
 binary-compatibility-validator-version = "0.18.1"
 kotlin-multiplatform-bignum-version = "0.3.10"

runtime/auth/aws-signing-default/common/test/aws/smithy/kotlin/runtime/auth/awssigning/SigV4aSignatureCalculatorTest.kt

@@ -4,7 +4,6 @@
  */
 package aws.smithy.kotlin.runtime.auth.awssigning
 
-import aws.smithy.kotlin.runtime.IgnoreNative
 import aws.smithy.kotlin.runtime.auth.awscredentials.Credentials
 import aws.smithy.kotlin.runtime.time.Instant
 import aws.smithy.kotlin.runtime.util.PlatformProvider
@@ -69,7 +68,6 @@ private val TESTS = listOf(
  * Tests for [SigV4aSignatureCalculator]. Currently only tests forming the string-to-sign.
  */
 class SigV4aSignatureCalculatorTest {
-    @IgnoreNative // FIXME test resources are not loadable on iOS: https://youtrack.jetbrains.com/issue/KT-49981/
     @Test
     fun testStringToSign() = TESTS.forEach { testId ->
         runTest {

runtime/auth/http-auth-aws/common/test/aws/smithy/kotlin/runtime/http/auth/AwsHttpSignerTestBase.kt

@@ -4,7 +4,6 @@
  */
 package aws.smithy.kotlin.runtime.http.auth
 
-import aws.smithy.kotlin.runtime.IgnoreNative
 import aws.smithy.kotlin.runtime.auth.awscredentials.Credentials
 import aws.smithy.kotlin.runtime.auth.awscredentials.CredentialsProvider
 import aws.smithy.kotlin.runtime.auth.awssigning.AwsSigner
@@ -127,7 +126,6 @@ public abstract class AwsHttpSignerTestBase(
         assertEquals(expectedSig, signed.headers["Authorization"])
     }
 
-    @IgnoreNative // FIXME Our JVM implementation does not sign `transfer-encoding`, but CRT does, causing a signature mismatch. Upgrade to latest version of aws-c-auth to get the fix.
     @Test
     public fun testSignAwsChunkedStreamNonReplayable(): TestResult = runTest {
         val op = buildOperation(streaming = true, replayable = false, requestBody = "a".repeat(AWS_CHUNKED_THRESHOLD + 1))
@@ -141,7 +139,6 @@ public abstract class AwsHttpSignerTestBase(
         assertEquals(expectedSig, signed.headers["Authorization"])
     }
 
-    @IgnoreNative // FIXME Our JVM implementation does not sign `transfer-encoding`, but CRT does, causing a signature mismatch. Upgrade to latest version of aws-c-auth to get the fix.
     @Test
     public fun testSignAwsChunkedStreamReplayable(): TestResult = runTest {
         val op = buildOperation(streaming = true, replayable = true, requestBody = "a".repeat(AWS_CHUNKED_THRESHOLD + 1))
@@ -155,7 +152,6 @@ public abstract class AwsHttpSignerTestBase(
         assertEquals(expectedSig, signed.headers["Authorization"])
     }
 
-    @IgnoreNative // FIXME Our JVM implementation does not sign `transfer-encoding`, but CRT does, causing a signature mismatch. Upgrade to latest version of aws-c-auth to get the fix.
     @Test
     public fun testSignOneShotStream(): TestResult = runTest {
         val op = buildOperation(streaming = true, replayable = false)

runtime/protocol/http-client-engines/http-client-engine-crt/jvmAndNative/test/aws/smithy/kotlin/runtime/http/engine/crt/AsyncStressTest.kt

@@ -5,13 +5,13 @@
 
 package aws.smithy.kotlin.runtime.http.engine.crt
 
-import aws.smithy.kotlin.runtime.IgnoreNative
 import aws.smithy.kotlin.runtime.http.HttpMethod
 import aws.smithy.kotlin.runtime.http.SdkHttpClient
 import aws.smithy.kotlin.runtime.http.complete
 import aws.smithy.kotlin.runtime.http.request.HttpRequestBuilder
 import aws.smithy.kotlin.runtime.http.request.url
 import aws.smithy.kotlin.runtime.httptest.TestWithLocalServer
+import aws.smithy.kotlin.runtime.io.use
 import aws.smithy.kotlin.runtime.net.Host
 import aws.smithy.kotlin.runtime.net.Scheme
 import io.ktor.server.cio.*
@@ -37,37 +37,38 @@ class AsyncStressTest : TestWithLocalServer() {
         }
     }.start()
 
-    @IgnoreNative // FIXME TlsContext needs to initialize CRT. Segmentation fault.
     @Test
     fun testStreamNotConsumed() = runBlocking {
         // test that filling the stream window and not consuming the body stream still cleans up resources
         // appropriately and allows requests to proceed (a stream that isn't consumed will be in a stuck state
         // if the window is full and never incremented again, this can lead to all connections being consumed
         // and the engine to no longer make further requests)
-        val client = SdkHttpClient(CrtHttpEngine())
-        val request = HttpRequestBuilder().apply {
-            url {
-                scheme = Scheme.HTTP
-                method = HttpMethod.GET
-                host = Host.Domain(testHost)
-                port = serverPort
-                path.decoded = "/largeResponse"
+        CrtHttpEngine().use { engine ->
+            val client = SdkHttpClient(engine)
+            val request = HttpRequestBuilder().apply {
+                url {
+                    scheme = Scheme.HTTP
+                    method = HttpMethod.GET
+                    host = Host.Domain(testHost)
+                    port = serverPort
+                    path.decoded = "/largeResponse"
+                }
             }
-        }
 
-        withTimeout(10.seconds) {
-            repeat(1_000) {
-                async {
-                    try {
-                        val call = client.call(request)
-                        yield()
-                        call.complete()
-                    } catch (ex: Exception) {
-                        println("exception on $it: $ex")
-                        throw ex
+            withTimeout(10.seconds) {
+                repeat(1_000) {
+                    async {
+                        try {
+                            val call = client.call(request)
+                            yield()
+                            call.complete()
+                        } catch (ex: Exception) {
+                            println("exception on $it: $ex")
+                            throw ex
+                        }
                     }
+                    yield()
                 }
-                yield()
             }
         }
     }

runtime/runtime-core/api/runtime-core.api

@@ -33,9 +33,6 @@ public final class aws/smithy/kotlin/runtime/ErrorMetadata$Companion {
 public abstract interface annotation class aws/smithy/kotlin/runtime/ExperimentalApi : java/lang/annotation/Annotation {
 }
 
-public abstract interface annotation class aws/smithy/kotlin/runtime/IgnoreNative : java/lang/annotation/Annotation {
-}
-
 public abstract interface annotation class aws/smithy/kotlin/runtime/InternalApi : java/lang/annotation/Annotation {
 }
 

runtime/runtime-core/common/src/aws/smithy/kotlin/runtime/Annotations.kt

@@ -71,9 +71,3 @@ public annotation class PlannedRemoval(
     val major: Int,
     val minor: Int,
 )
-
-/**
- * Marks a test that should be ignored on Native platforms
- */
-@Target(AnnotationTarget.CLASS, AnnotationTarget.FUNCTION)
-public expect annotation class IgnoreNative()