Skip to content

Commit eeeaa9e

Browse files
committed
IgnoreNative
1 parent ebe6116 commit eeeaa9e

File tree

33 files changed

+155
-104
lines changed

33 files changed

+155
-104
lines changed

runtime/auth/aws-credentials/common/test/aws/smithy/kotlin/runtime/auth/awscredentials/CachedCredentialsProviderTest.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
package aws.smithy.kotlin.runtime.auth.awscredentials
77

8+
import aws.smithy.kotlin.runtime.IgnoreNative
89
import aws.smithy.kotlin.runtime.collections.Attributes
910
import aws.smithy.kotlin.runtime.time.Instant
1011
import aws.smithy.kotlin.runtime.time.ManualClock
@@ -37,7 +38,7 @@ class CachedCredentialsProviderTest {
3738
}
3839
}
3940

40-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
41+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
4142
@Test
4243
fun testLoadFirstCall() = runTest {
4344
// explicit expiration
@@ -52,7 +53,7 @@ class CachedCredentialsProviderTest {
5253
assertEquals(1, source.callCount)
5354
}
5455

55-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
56+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
5657
@Test
5758
fun testDefaultExpiration() = runTest {
5859
// expiration should come from the cached provider

runtime/auth/aws-signing-common/common/test/aws/smithy/kotlin/runtime/auth/awssigning/PresignerTest.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
*/
55
package aws.smithy.kotlin.runtime.auth.awssigning
66

7+
import aws.smithy.kotlin.runtime.IgnoreNative
78
import aws.smithy.kotlin.runtime.auth.awscredentials.Credentials
89
import aws.smithy.kotlin.runtime.auth.awscredentials.CredentialsProvider
910
import aws.smithy.kotlin.runtime.client.endpoints.Endpoint
@@ -25,14 +26,14 @@ import kotlin.test.assertTrue
2526
class PresignerTest {
2627
// Verify that custom endpoint URL schemes aren't changed.
2728
// See https://github.com/awslabs/aws-sdk-kotlin/issues/938
28-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
29+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
2930
@Test
3031
fun testSignedUrlAllowsHttp() = testSigningUrl("http://localhost:8080/path/to/resource?foo=bar")
3132

3233
// Verify that custom endpoint URL schemes aren't changed.
3334
// See https://github.com/awslabs/aws-sdk-kotlin/issues/938
3435
@Test
35-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
36+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
3637
fun testSignedUrlAllowsHttps() = testSigningUrl("https://localhost:8088/path/to/resource?bar=foo")
3738

3839
private fun testSigningUrl(url: String) = runTest {

runtime/auth/aws-signing-default/common/test/aws/smithy/kotlin/runtime/auth/awssigning/DefaultCanonicalizerTest.kt

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
*/
55
package aws.smithy.kotlin.runtime.auth.awssigning
66

7+
import aws.smithy.kotlin.runtime.IgnoreNative
78
import aws.smithy.kotlin.runtime.auth.awscredentials.Credentials
89
import aws.smithy.kotlin.runtime.auth.awssigning.tests.DEFAULT_TEST_CREDENTIALS
910
import aws.smithy.kotlin.runtime.http.*
@@ -19,7 +20,7 @@ import kotlin.test.assertEquals
1920

2021
class DefaultCanonicalizerTest {
2122
// Test adapted from https://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html
22-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
23+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
2324
@Test
2425
fun testCanonicalize() = runTest {
2526
val request = HttpRequest {
@@ -80,7 +81,7 @@ class DefaultCanonicalizerTest {
8081
}
8182

8283
// Targeted test for proper URI path escaping. See https://github.com/smithy-lang/smithy-kotlin/issues/657
83-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
84+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
8485
@Test
8586
fun testEscapablePath() {
8687
val uri = Url.Builder()
@@ -97,7 +98,7 @@ class DefaultCanonicalizerTest {
9798
assertEquals("/2013-04-01/healthcheck/foo%253Cbar%253Ebaz%253C%252Fbar%253E", uri.canonicalPath(config))
9899
}
99100

100-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
101+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
101102
@Test
102103
fun testCanonicalPath() {
103104
val config = AwsSigningConfig {
@@ -113,7 +114,7 @@ class DefaultCanonicalizerTest {
113114
assertEquals("/foo/%40bar/baz%253Cqux%253Aquux", uri.canonicalPath(config))
114115
}
115116

116-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
117+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
117118
@Test
118119
fun testCanonicalQueryParams() {
119120
Url.Builder().apply {
@@ -128,7 +129,7 @@ class DefaultCanonicalizerTest {
128129
}
129130
}
130131

131-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
132+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
132133
@Test
133134
fun testUnsignedHeaders() = runTest {
134135
val request = HttpRequest {
@@ -161,7 +162,7 @@ class DefaultCanonicalizerTest {
161162
assertEquals(expectedSignedHeaders, actual.signedHeaders)
162163
}
163164

164-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
165+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
165166
@Test
166167
fun testCustomPort() = runTest {
167168
val request = HttpRequest {

runtime/auth/aws-signing-default/common/test/aws/smithy/kotlin/runtime/auth/awssigning/DefaultRequestMutatorTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,19 @@
44
*/
55
package aws.smithy.kotlin.runtime.auth.awssigning
66

7+
import aws.smithy.kotlin.runtime.IgnoreNative
78
import aws.smithy.kotlin.runtime.auth.awscredentials.Credentials
89
import aws.smithy.kotlin.runtime.http.Headers
910
import aws.smithy.kotlin.runtime.http.HttpBody
1011
import aws.smithy.kotlin.runtime.http.HttpMethod
1112
import aws.smithy.kotlin.runtime.http.request.*
1213
import aws.smithy.kotlin.runtime.net.Host
1314
import aws.smithy.kotlin.runtime.time.Instant
14-
import kotlin.test.Ignore
1515
import kotlin.test.Test
1616
import kotlin.test.assertEquals
1717

1818
class DefaultRequestMutatorTest {
19-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
19+
@IgnoreNative // FIXME Re-enable after Kotlin/Native implementation
2020
@Test
2121
fun testAppendAuthHeader() {
2222
val canonical = CanonicalRequest(baseRequest.toBuilder(), "", "action;host;x-amz-date", "")

runtime/auth/aws-signing-default/common/test/aws/smithy/kotlin/runtime/auth/awssigning/DefaultSignatureCalculatorTest.kt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
*/
55
package aws.smithy.kotlin.runtime.auth.awssigning
66

7+
import aws.smithy.kotlin.runtime.IgnoreNative
78
import aws.smithy.kotlin.runtime.auth.awscredentials.Credentials
89
import aws.smithy.kotlin.runtime.auth.awssigning.tests.DEFAULT_TEST_CREDENTIALS
910
import aws.smithy.kotlin.runtime.hashing.sha256
@@ -17,7 +18,7 @@ import kotlin.test.assertEquals
1718

1819
class DefaultSignatureCalculatorTest {
1920
// Test adapted from https://docs.aws.amazon.com/general/latest/gr/sigv4-calculate-signature.html
20-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
21+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
2122
@Test
2223
fun testCalculate() {
2324
val signingKey = "c4afb1cc5771d871763a393e44b703571b55cc28424d1a5e86da6ed3c154a4b9".decodeHexBytes()
@@ -34,7 +35,7 @@ class DefaultSignatureCalculatorTest {
3435
}
3536

3637
// Test adapted from https://docs.aws.amazon.com/general/latest/gr/sigv4-calculate-signature.html
37-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
38+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
3839
@Test
3940
fun testSigningKey() = runTest {
4041
val config = AwsSigningConfig {
@@ -50,7 +51,7 @@ class DefaultSignatureCalculatorTest {
5051
}
5152

5253
// Test adapted from https://docs.aws.amazon.com/general/latest/gr/sigv4-create-string-to-sign.html
53-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
54+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
5455
@Test
5556
fun testStringToSign() {
5657
val canonicalRequest = """
@@ -84,7 +85,7 @@ class DefaultSignatureCalculatorTest {
8485

8586
private data class ChunkStringToSignTest(val signatureType: AwsSignatureType, val expectedNonSignatureHeaderHash: String)
8687

87-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
88+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
8889
@Test
8990
fun testChunkStringToSign() {
9091
// Test event stream signing

runtime/auth/aws-signing-tests/common/src/aws/smithy/kotlin/runtime/auth/awssigning/tests/AwsChunkedByteReadChannelTestBase.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
package aws.smithy.kotlin.runtime.auth.awssigning.tests
77

8+
import aws.smithy.kotlin.runtime.IgnoreNative
89
import aws.smithy.kotlin.runtime.auth.awssigning.*
910
import aws.smithy.kotlin.runtime.auth.awssigning.internal.CHUNK_SIZE_BYTES
1011
import aws.smithy.kotlin.runtime.io.*
@@ -17,7 +18,7 @@ import kotlin.test.*
1718
import kotlin.time.Duration.Companion.milliseconds
1819

1920
abstract class AwsChunkedByteReadChannelTestBase : AwsChunkedTestBase(AwsChunkedReaderFactory.Channel) {
20-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
21+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
2122
@Test
2223
fun testSlowProducerMultipleChunksPartialLast(): TestResult = runTest {
2324
val numChunks = 6

runtime/auth/aws-signing-tests/common/src/aws/smithy/kotlin/runtime/auth/awssigning/tests/AwsChunkedTestBase.kt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ abstract class AwsChunkedTestBase(
171171
return length
172172
}
173173

174-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
174+
@Ignore // FIXME Re-enable after Kotlin/Native Implementation
175175
@Test
176176
fun testReadNegativeOffset(): TestResult = runTest {
177177
val dataLengthBytes = CHUNK_SIZE_BYTES
@@ -185,7 +185,7 @@ abstract class AwsChunkedTestBase(
185185
}
186186
}
187187

188-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
188+
@Ignore // FIXME Re-enable after Kotlin/Native Implementation
189189
@Test
190190
fun testReadExactBytes(): TestResult = runTest {
191191
val dataLengthBytes = CHUNK_SIZE_BYTES
@@ -219,7 +219,7 @@ abstract class AwsChunkedTestBase(
219219
assertTrue(awsChunked.isClosedForRead())
220220
}
221221

222-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
222+
@Ignore // FIXME Re-enable after Kotlin/Native Implementation
223223
@Test
224224
fun testReadExcessiveBytes(): TestResult = runTest {
225225
val dataLengthBytes = CHUNK_SIZE_BYTES
@@ -249,7 +249,7 @@ abstract class AwsChunkedTestBase(
249249
assertTrue(awsChunked.isClosedForRead())
250250
}
251251

252-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
252+
@Ignore // FIXME Re-enable after Kotlin/Native Implementation
253253
@Test
254254
fun testReadFewerBytes(): TestResult = runTest {
255255
val dataLengthBytes = CHUNK_SIZE_BYTES
@@ -276,7 +276,7 @@ abstract class AwsChunkedTestBase(
276276
assertFalse(awsChunked.isClosedForRead())
277277
}
278278

279-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
279+
@Ignore // FIXME Re-enable after Kotlin/Native Implementation
280280
@Test
281281
fun testReadMultipleFullChunks(): TestResult = runTest {
282282
val numChunks = 5
@@ -324,7 +324,7 @@ abstract class AwsChunkedTestBase(
324324
assertTrue(awsChunked.isClosedForRead())
325325
}
326326

327-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
327+
@Ignore // FIXME Re-enable after Kotlin/Native Implementation
328328
@Test
329329
fun testReadMultipleChunksLastChunkNotFull(): TestResult = runTest {
330330
val numChunks = 6

runtime/auth/aws-signing-tests/common/src/aws/smithy/kotlin/runtime/auth/awssigning/tests/BasicSigningTestBase.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
*/
55
package aws.smithy.kotlin.runtime.auth.awssigning.tests
66

7+
import aws.smithy.kotlin.runtime.IgnoreNative
78
import aws.smithy.kotlin.runtime.auth.awscredentials.Credentials
89
import aws.smithy.kotlin.runtime.auth.awssigning.*
910
import aws.smithy.kotlin.runtime.http.HttpBody
@@ -18,7 +19,6 @@ import aws.smithy.kotlin.runtime.net.url.Url
1819
import aws.smithy.kotlin.runtime.time.Instant
1920
import kotlinx.coroutines.test.TestResult
2021
import kotlinx.coroutines.test.runTest
21-
import kotlin.test.Ignore
2222
import kotlin.test.Test
2323
import kotlin.test.assertEquals
2424
import kotlin.test.assertFalse
@@ -56,7 +56,7 @@ public abstract class BasicSigningTestBase : HasSigner {
5656
credentials = DEFAULT_TEST_CREDENTIALS
5757
}
5858

59-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
59+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
6060
@Test
6161
public fun testSignRequestSigV4(): TestResult = runTest {
6262
// sanity test
@@ -85,7 +85,7 @@ public abstract class BasicSigningTestBase : HasSigner {
8585
assertEquals(expectedSig, result.signature.decodeToString())
8686
}
8787

88-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
88+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
8989
@Test
9090
public open fun testSignRequestSigV4Asymmetric(): TestResult = runTest {
9191
// sanity test
@@ -168,7 +168,7 @@ public abstract class BasicSigningTestBase : HasSigner {
168168
return chunk
169169
}
170170

171-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
171+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
172172
@Test
173173
public fun testSignChunks(): TestResult = runTest {
174174
val request = createChunkedTestRequest()
@@ -192,7 +192,7 @@ public abstract class BasicSigningTestBase : HasSigner {
192192
assertEquals(EXPECTED_FINAL_CHUNK_SIGNATURE, finalChunkResult.signature.decodeToString())
193193
}
194194

195-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
195+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
196196
@Test
197197
public fun testSigningCopiesInput(): TestResult = runTest {
198198
// sanity test the signer doesn't mutate the input and instead copies to a new request

runtime/auth/http-auth-aws/common/test/aws/smithy/kotlin/runtime/http/auth/AwsHttpSignerTestBase.kt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
*/
55
package aws.smithy.kotlin.runtime.http.auth
66

7+
import aws.smithy.kotlin.runtime.IgnoreNative
78
import aws.smithy.kotlin.runtime.auth.awscredentials.Credentials
89
import aws.smithy.kotlin.runtime.auth.awscredentials.CredentialsProvider
910
import aws.smithy.kotlin.runtime.auth.awssigning.AwsSigner
@@ -106,7 +107,7 @@ public abstract class AwsHttpSignerTestBase(
106107
return operation.context[HttpOperationContext.HttpCallList].last().request
107108
}
108109

109-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
110+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
110111
@Test
111112
public fun testSignRequest(): TestResult = runTest {
112113
val op = buildOperation()
@@ -120,7 +121,7 @@ public abstract class AwsHttpSignerTestBase(
120121
assertEquals(expectedSig, signed.headers["Authorization"])
121122
}
122123

123-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
124+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
124125
@Test
125126
public fun testUnsignedRequest(): TestResult = runTest {
126127
val op = buildOperation(unsigned = true)
@@ -134,7 +135,7 @@ public abstract class AwsHttpSignerTestBase(
134135
assertEquals(expectedSig, signed.headers["Authorization"])
135136
}
136137

137-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
138+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
138139
@Test
139140
public fun testSignReplayableStreamingRequest(): TestResult = runTest {
140141
val op = buildOperation(streaming = true)
@@ -148,7 +149,7 @@ public abstract class AwsHttpSignerTestBase(
148149
assertEquals(expectedSig, signed.headers["Authorization"])
149150
}
150151

151-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
152+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
152153
@Test
153154
public fun testSignAwsChunkedStreamNonReplayable(): TestResult = runTest {
154155
val op = buildOperation(streaming = true, replayable = false, requestBody = "a".repeat(AWS_CHUNKED_THRESHOLD + 1))

runtime/protocol/aws-protocol-core/common/test/ClockSkewInterceptorTest.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
*/
55
package aws.smithy.kotlin.runtime.awsprotocol
66

7+
import aws.smithy.kotlin.runtime.IgnoreNative
78
import aws.smithy.kotlin.runtime.SdkBaseException
89
import aws.smithy.kotlin.runtime.ServiceErrorMetadata
910
import aws.smithy.kotlin.runtime.awsprotocol.ClockSkewInterceptor.Companion.CLOCK_SKEW_THRESHOLD
@@ -31,7 +32,7 @@ private val POSSIBLE_SKEWED_RESPONSE_CODE_DESCRIPTION = "InvalidSignatureExcepti
3132
private val NOT_SKEWED_RESPONSE_CODE_DESCRIPTION = "RequestThrottled"
3233

3334
class ClockSkewInterceptorTest {
34-
@Ignore // FIXME Re-enable after Kotlin/Native implementation
35+
@IgnoreNative // FIXME Re-enable after Kotlin/Native Implementation
3536
@Test
3637
fun testNotSkewed() {
3738
val clientTime = Instant.fromRfc5322("Wed, 6 Oct 2023 16:20:50 -0400")

0 commit comments

Comments
 (0)