Skip to content

Commit fb52307

Browse files
committed
Add a TODO
1 parent 08a7ef8 commit fb52307

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

runtime/auth/aws-signing-default/common/test/aws/smithy/kotlin/runtime/auth/awssigning/SigV4aSignatureCalculatorTest.kt

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@ import kotlin.test.assertTrue
1818
private const val SIGV4A_RESOURCES_BASE = "common/test/resources/sigv4a"
1919

2020
/**
21-
* Tests which are defined in resources/sigv4a
21+
* Tests which are defined in resources/sigv4a.
22+
* Copied directly from https://github.com/awslabs/aws-c-auth/tree/e8360a65e0f3337d4ac827945e00c3b55a641a5f/tests/aws-signing-test-suite/v4a.
23+
* get-vanilla-query-order-key and get-vanilla-query-order-value were deleted since they are not complete tests.
2224
*/
2325
private val TESTS = listOf(
2426
"get-header-key-duplicate",
@@ -61,6 +63,12 @@ private val TESTS = listOf(
6163
"post-x-www-form-urlencoded-parameters",
6264
)
6365

66+
/**
67+
* Tests for [SigV4aSignatureCalculator]. Currently only tests forming the string-to-sign.
68+
*
69+
* TODO Add tests against header-signature.txt when java.security implements RFC 6979 / deterministic ECDSA.
70+
* https://bugs.openjdk.org/browse/JDK-8239382
71+
*/
6472
class SigV4aSignatureCalculatorTest {
6573
@Test
6674
fun testStringToSign() = TESTS.forEach { testId ->

runtime/auth/aws-signing-default/common/test/resources/sigv4a/README.md

Lines changed: 0 additions & 2 deletions
This file was deleted.

0 commit comments

Comments
 (0)