feat: sdk source readRemaining #1454
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0marperez
added
the
no-changelog
lauzadis
reviewed
Oct 30, 2025
| * @param sink the buffer that data read from the source will be appended to | ||
| */ | ||
| @InternalApi | ||
| public fun SdkSource.readRemaining(sink: SdkBuffer) { |
There was a problem hiding this comment.
I think this should return the total bytes read
lauzadis
reviewed
Oct 31, 2025
| totalReadBytes += readBytes | ||
| } while (readBytes != -1L) | ||
|
|
||
| return totalReadBytes + 1L // Account for last -1 read |
There was a problem hiding this comment.
I don't think we should be counting the -1L. Can you write some unit tests for this function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
N/A
Description of changes
Used by aws/aws-sdk-kotlin#1712
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.