appease pyright (for now...)

Author: haydenbaker

packages/smithy-core/src/smithy_core/aio/types.py

@@ -46,14 +46,14 @@ async def read(self, size: int = -1) -> bytes:
         if self._closed or not self._data:
             raise ValueError("I/O operation on closed file.")
 
-        if isinstance(self._data, BytesReader) and not iscoroutinefunction(
+        if isinstance(self._data, BytesReader) and not iscoroutinefunction( # type: ignore - TODO(pyright)
             self._data.read
         ):
             # Python's runtime_checkable can't actually tell the difference between
             # sync and async, so we have to check ourselves.
             return self._data.read(size)
 
-        if isinstance(self._data, AsyncByteStream):
+        if isinstance(self._data, AsyncByteStream):  # type: ignore - TODO(pyright)
             return await self._data.read(size)
 
         return await self._read_from_iterable(
@@ -135,7 +135,7 @@ def __init__(self, data: StreamingBlob):
         if isinstance(data, bytes | bytearray):
             self._buffer = BytesIO(data)
             self._data_source = None
-        elif isinstance(data, AsyncByteStream) and iscoroutinefunction(data.read):
+        elif isinstance(data, AsyncByteStream) and iscoroutinefunction(data.read): # type: ignore - TODO(pyright)
             # Note that we need that iscoroutine check because python won't actually check
             # whether or not the read function is async.
             self._buffer = BytesIO()

packages/smithy-core/src/smithy_core/schemas.py

@@ -162,10 +162,10 @@ def collection(
     def member(
         cls,
         id: ShapeID,
-        target: Self,
+        target: "Schema",
         index: int,
         member_traits: list["Trait"] | None = None,
-    ) -> Self:
+    ) -> "Schema":
         """Create a schema for a member shape.
 
         Member schemas are largely copies of the schemas they target to make it easier

packages/smithy-http/src/smithy_http/__init__.py

@@ -113,7 +113,7 @@ def __init__(
                 f"{', '.join(non_unique_names)}."
             )
         init_tuples = zip(init_field_names, init_fields)
-        self.entries: OrderedDict[str, interfaces.Field] = OrderedDict(init_tuples)
+        self.entries: dict[str, interfaces.Field] = OrderedDict(init_tuples)
         self.encoding: str = encoding
 
     def set_field(self, field: interfaces.Field) -> None:

packages/smithy-http/src/smithy_http/interfaces/__init__.py

@@ -72,7 +72,7 @@ class Fields(Protocol):
 
     # Entries are keyed off the name of a provided Field
     entries: dict[str, Field]
-    encoding: str | None = "utf-8"
+    encoding: str = "utf-8"
 
     def set_field(self, field: Field) -> None:
         """Alias for __setitem__ to utilize the field.name for the entry key."""

packages/smithy-http/tests/integration/aio/conftest.py

@@ -17,9 +17,10 @@ def sample_request() -> HTTPRequest:
             Field(name="user-agent", values=["smithy-python-test"]),
         ]
     )
+    b: list[bytes] = []
     return HTTPRequest(
         method="GET",
         destination=URI(host="aws.amazon.com"),
         fields=headers,
-        body=async_list([]),
+        body=async_list(b),
     )