Cleanups from PR

Author: alextwoods

packages/smithy-http/src/smithy_http/aio/crt.py

@@ -174,15 +174,13 @@ def on_response(
                     kind=FieldPosition.HEADER,
                 )
 
-        response = AWSCRTHTTPResponse(
-            status=status_code,
-            fields=fields,
-            body=self._body,
-        )
-        if status_code != 200 and status_code >= 300:
-            self._response_future.set_exception(CRTErrorResponse(response))
-        else:
-            self._response_future.set_result(response)
+            self._response_future.set_result(
+                AWSCRTHTTPResponse(
+                    status=status_code,
+                    fields=fields,
+                    body=self._body,
+                )
+            )
 
     async def await_response(self) -> AWSCRTHTTPResponse:
         return await asyncio.wrap_future(self._response_future)
@@ -195,18 +193,6 @@ def _cancel(self, completion_future: ConcurrentFuture[int | Exception]) -> None:
             self._response_future.cancel()
 
 
-class CRTErrorResponse(Exception):
-    def __init__(self, response: AWSCRTHTTPResponse) -> None:
-        self._status = response.status
-        self._response = response
-
-        super().__init__(f"Request failed with status code {self._status}")
-
-    @property
-    def response(self) -> AWSCRTHTTPResponse:
-        return self._response
-
-
 ConnectionPoolKey = tuple[str, str, int | None]
 ConnectionPoolDict = dict[ConnectionPoolKey, "crt_http.HttpClientConnection"]
 
@@ -265,11 +251,12 @@ async def send(
         crt_stream.completion_future.add_done_callback(
             partial(self._close_input_body, body=crt_body)
         )
-        try:
-            return await response_factory.await_response()
-        except CRTErrorResponse as e:
+
+        response = await response_factory.await_response()
+        if response.status != 200 and response.status >= 300:
             await close(crt_body)
-            return e.response
+
+        return response
 
     def _close_input_body(
         self, future: ConcurrentFuture[int], *, body: "BufferableByteStream | BytesIO"