Skip to content

Commit 9f4486f

Browse files
committed
Cleanup dead code
1 parent b65ba40 commit 9f4486f

File tree

1 file changed

+2
-14
lines changed
  • packages/aws-sdk-signers/src/aws_sdk_signers

1 file changed

+2
-14
lines changed

packages/aws-sdk-signers/src/aws_sdk_signers/signers.py

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -99,12 +99,6 @@ def sign(
9999
)
100100

101101
signing_fields = self._normalize_signing_fields(request=new_request)
102-
# If any headers have been added, make sure those are reflected in the new request
103-
for field_name, field_value in signing_fields.items():
104-
if field_name not in request.fields:
105-
new_request.fields.set_field(
106-
Field(name=field_name, values=[field_value])
107-
)
108102
credential_scope = self._scope(signing_properties=new_signing_properties)
109103
credential = f"{identity.access_key_id}/{credential_scope}"
110104
authorization = self.generate_authorization_field(
@@ -219,7 +213,7 @@ def _apply_required_fields(
219213
Field(name="X-Amz-Security-Token", values=[identity.session_token])
220214
)
221215
if "host" not in request.fields:
222-
host = self._normalize_host_field(uri=request.destination)
216+
host = self._normalize_host_field(uri=request.destination) # type: ignore - TODO(pyright)
223217
request.fields.set_field(Field(name="host", values=[host]))
224218

225219
def canonical_request(
@@ -483,12 +477,6 @@ async def sign(
483477
)
484478

485479
signing_fields = await self._normalize_signing_fields(request=new_request)
486-
# If any headers have been added, make sure those are reflected in the new request
487-
for field_name, field_value in signing_fields.items():
488-
if field_name not in request.fields:
489-
new_request.fields.set_field(
490-
Field(name=field_name, values=[field_value])
491-
)
492480
credential_scope = await self._scope(signing_properties=new_signing_properties)
493481
credential = f"{identity.access_key_id}/{credential_scope}"
494482
authorization = await self.generate_authorization_field(
@@ -603,7 +591,7 @@ async def _apply_required_fields(
603591
Field(name="X-Amz-Security-Token", values=[identity.session_token])
604592
)
605593
if "host" not in request.fields:
606-
host = await self._normalize_host_field(uri=request.destination)
594+
host = await self._normalize_host_field(uri=request.destination) # type: ignore - TODO(pyright)
607595
request.fields.set_field(Field(name="host", values=[host]))
608596

609597
async def canonical_request(

0 commit comments

Comments
 (0)