Add new ruff lint rules (#392)

* Add ruff lint rule - C4, I, PIE, RUF, T, UP
* Re-run ruff format
* Fix typing issue in ApiKeySigner
* Fix import order in tests for sub-projects

Author: haydenbaker

packages/aws-event-stream/pyproject.toml

@@ -17,3 +17,6 @@ build-backend = "hatchling.build"
 exclude = [
   "tests",
 ]
+
+[tool.ruff]
+src = ["src"]

packages/aws-event-stream/src/aws_event_stream/events.py

@@ -15,6 +15,7 @@
 from dataclasses import dataclass
 from io import BytesIO
 from struct import pack, unpack
+from types import MappingProxyType
 from typing import Literal, Self
 
 from smithy_core.aio.interfaces import AsyncByteStream
@@ -610,11 +611,13 @@ class _DecodeUtils:
     INT64_BYTE_FORMAT = "!q"
 
     # uint byte size to unpack format
-    UINT_BYTE_FORMAT: dict[_ArraySize, str] = {
-        1: UINT8_BYTE_FORMAT,
-        2: UINT16_BYTE_FORMAT,
-        4: UINT32_BYTE_FORMAT,
-    }
+    UINT_BYTE_FORMAT: Mapping[_ArraySize, str] = MappingProxyType(
+        {
+            1: UINT8_BYTE_FORMAT,
+            2: UINT16_BYTE_FORMAT,
+            4: UINT32_BYTE_FORMAT,
+        }
+    )
 
     @staticmethod
     def unpack_uint8(data: BytesLike) -> tuple[int, int]:
@@ -749,20 +752,24 @@ class EventHeaderDecoder(Iterator[tuple[str, HEADER_VALUE]]):
 
     # Maps header type to appropriate unpacking function
     # These unpacking functions return the value and the amount unpacked
-    _HEADER_TYPE_MAP: dict[int, Callable[[BytesLike], tuple[HEADER_VALUE, int]]] = {
-        # Boolean headers have no data bytes following the type signifier, so they
-        # can just return static values.
-        0: lambda b: (True, 0),  # boolean_true
-        1: lambda b: (False, 0),  # boolean_false
-        2: _DecodeUtils.unpack_int8,  # byte
-        3: _DecodeUtils.unpack_int16,  # short
-        4: _DecodeUtils.unpack_int32,  # integer
-        5: _DecodeUtils.unpack_int64,  # long
-        6: _DecodeUtils.unpack_byte_array,  # byte_array
-        7: _DecodeUtils.unpack_utf8_string,  # string
-        8: _DecodeUtils.unpack_timestamp,  # timestamp
-        9: _DecodeUtils.unpack_uuid,  # uuid
-    }
+    _HEADER_TYPE_MAP: Mapping[int, Callable[[BytesLike], tuple[HEADER_VALUE, int]]] = (
+        MappingProxyType(
+            {
+                # Boolean headers have no data bytes following the type signifier, so they
+                # can just return static values.
+                0: lambda b: (True, 0),  # boolean_true
+                1: lambda b: (False, 0),  # boolean_false
+                2: _DecodeUtils.unpack_int8,  # byte
+                3: _DecodeUtils.unpack_int16,  # short
+                4: _DecodeUtils.unpack_int32,  # integer
+                5: _DecodeUtils.unpack_int64,  # long
+                6: _DecodeUtils.unpack_byte_array,  # byte_array
+                7: _DecodeUtils.unpack_utf8_string,  # string
+                8: _DecodeUtils.unpack_timestamp,  # timestamp
+                9: _DecodeUtils.unpack_uuid,  # uuid
+            }
+        )
+    )
 
     def __init__(self, header_bytes: BytesLike) -> None:
         """Initialize an event header decoder.

packages/smithy-aws-core/pyproject.toml

@@ -16,3 +16,6 @@ build-backend = "hatchling.build"
 exclude = [
   "tests",
 ]
+
+[tool.ruff]
+src = ["src"]

packages/smithy-core/pyproject.toml

@@ -19,3 +19,6 @@ build-backend = "hatchling.build"
 exclude = [
   "tests",
 ]
+
+[tool.ruff]
+src = ["src"]

packages/smithy-core/src/smithy_core/documents.py

@@ -230,7 +230,7 @@ def _wrap_map(self, value: Mapping[str, DocumentValue]) -> dict[str, "Document"]
                 member_schema = self._schema.members["value"]
             return {k: self._new_document(v, member_schema) for k, v in value.items()}
 
-        result: dict[str, "Document"] = {}
+        result: dict[str, Document] = {}
         for k, v in value.items():
             result[k] = self._new_document(v, self._schema.members[k])
         return result

packages/smithy-core/src/smithy_core/identity.py

@@ -1,6 +1,6 @@
 #  Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 #  SPDX-License-Identifier: Apache-2.0
-from datetime import datetime, timezone
+from datetime import UTC, datetime
 
 from .interfaces import identity as identity_interface
 from .utils import ensure_utc
@@ -28,4 +28,4 @@ def is_expired(self) -> bool:
         """Whether the identity is expired."""
         if self.expiration is None:
             return False
-        return datetime.now(tz=timezone.utc) >= self.expiration
+        return datetime.now(tz=UTC) >= self.expiration

packages/smithy-core/src/smithy_core/interceptors.py

@@ -148,7 +148,6 @@ def read_before_execution(
         the `response`. If multiple `read_before_execution` methods throw exceptions,
         the latest will be used and earlier ones will be logged and dropped.
         """
-        pass
 
     def modify_before_serialization(
         self, context: InterceptorContext[Request, None, None, None]
@@ -193,7 +192,6 @@ def read_before_serialization(
         If exceptions are thrown by this hook, execution will jump to
         `modify_before_completion` with the thrown exception as the `response`.
         """
-        pass
 
     def read_after_serialization(
         self, context: InterceptorContext[Request, None, TransportRequest, None]
@@ -214,7 +212,6 @@ def read_after_serialization(
         If exceptions are thrown by this hook, execution will jump to
         `modify_before_completion` with the thrown exception as the `response`.
         """
-        pass
 
     def modify_before_retry_loop(
         self, context: InterceptorContext[Request, None, TransportRequest, None]
@@ -259,7 +256,6 @@ def read_before_attempt(
         exception as the `response` If multiple `read_before_attempt` methods throw
         exceptions, the latest will be used and earlier ones will be logged and dropped.
         """
-        pass
 
     def modify_before_signing(
         self, context: InterceptorContext[Request, None, TransportRequest, None]
@@ -309,7 +305,6 @@ def read_before_signing(
         If exceptions are thrown by this hook, execution will jump to
         `modify_before_attempt_completion` with the thrown exception as the `response`.
         """
-        pass
 
     def read_after_signing(
         self, context: InterceptorContext[Request, None, TransportRequest, None]
@@ -333,7 +328,6 @@ def read_after_signing(
         If exceptions are thrown by this hook, execution will jump to
         `modify_before_attempt_completion` with the thrown exception as the `response`.
         """
-        pass
 
     def modify_before_transmit(
         self, context: InterceptorContext[Request, None, TransportRequest, None]
@@ -384,7 +378,6 @@ def read_before_transmit(
         If exceptions are thrown by this hook, execution will jump to
         `modify_before_attempt_completion` with the thrown exception as the `response`.
         """
-        pass
 
     def read_after_transmit(
         self,
@@ -411,7 +404,6 @@ def read_after_transmit(
         If exceptions are thrown by this hook, execution will jump to
         `modify_before_attempt_completion` with the thrown exception as the `response`.
         """
-        pass
 
     def modify_before_deserialization(
         self,
@@ -467,7 +459,6 @@ def read_before_deserialization(
         If exceptions are thrown by this hook, execution will jump to
         `modify_before_attempt_completion` with the thrown exception as the `response`.
         """
-        pass
 
     def read_after_deserialization(
         self,
@@ -495,7 +486,6 @@ def read_after_deserialization(
         If exceptions are thrown by this hook, execution will jump to
         `modify_before_attempt_completion` with the thrown exception as the `response`.
         """
-        pass
 
     def modify_before_attempt_completion(
         self,
@@ -554,7 +544,6 @@ def read_after_attempt(
         execution will then jump to `read_before_attempt`. Otherwise, execution will
         jump to `modify_before_completion` with the thrown exception as the `response`.
         """
-        pass
 
     def modify_before_completion(
         self,
@@ -605,4 +594,3 @@ def read_after_execution(
         final response. If multiple `read_after_execution` methods throw exceptions,
         the latest will be used and earlier ones will be logged and dropped.
         """
-        pass

packages/smithy-core/src/smithy_core/interfaces/identity.py

@@ -25,8 +25,6 @@ def is_expired(self) -> bool:
 class IdentityProperties(TypedDict):
     """Properties used to help determine the identity to return."""
 
-    ...
-
 
 IdentityPropertiesType = TypeVar("IdentityPropertiesType", bound=IdentityProperties)
 IdentityPropertiesType_contra = TypeVar(

packages/smithy-core/src/smithy_core/retries.py

@@ -242,4 +242,3 @@ def refresh_retry_token_for_retry(
 
     def record_success(self, *, token: retries_interface.RetryToken) -> None:
         """Not used by this retry strategy."""
-        pass

packages/smithy-core/src/smithy_core/schemas.py

@@ -50,8 +50,8 @@ def __init__(
         if any(_member_props) and not all(_member_props):
             raise SmithyException(
                 "If any member property is set, all member properties must be set. "
-                f"member_name: {repr(id.member)}, member_target: "
-                f"{repr(member_target)}, member_index: {repr(member_index)}"
+                f"member_name: {id.member!r}, member_target: "
+                f"{member_target!r}, member_index: {member_index!r}"
             )
 
         # setattr is required because the class is frozen
@@ -67,7 +67,7 @@ def __init__(
 
         if members:
             if isinstance(members, list):
-                m: dict[str, "Schema"] = {}
+                m: dict[str, Schema] = {}
                 for member in members:
                     m[member.expect_member_name()] = member
                 members = m
@@ -140,7 +140,7 @@ def collection(
             constructor, this is a dict of member names to a simplified dict containing
             only ``traits`` and a ``target``. Member schemas will be generated from this.
         """
-        struct_members: dict[str, "Schema"] = {}
+        struct_members: dict[str, Schema] = {}
         if members:
             for k in members.keys():
                 struct_members[k] = cls.member(