Add ruff lint rule - I

haydenbaker · haydenbaker · commit bf2305a706ad · 2025-02-26T08:29:32.000-08:00
diff --git a/packages/aws-event-stream/tests/unit/_private/__init__.py b/packages/aws-event-stream/tests/unit/_private/__init__.py
@@ -4,6 +4,7 @@
 from dataclasses import dataclass
 from typing import Any, ClassVar, Literal, Self
 
+from aws_event_stream.events import Byte, EventMessage, Long, Short
 from smithy_core.deserializers import ShapeDeserializer
 from smithy_core.exceptions import SmithyException
 from smithy_core.prelude import (
@@ -21,8 +22,6 @@
 from smithy_core.shapes import ShapeID, ShapeType
 from smithy_core.traits import Trait
 
-from aws_event_stream.events import Byte, EventMessage, Long, Short
-
 EVENT_HEADER_TRAIT = Trait(id=ShapeID("smithy.api#eventHeader"))
 EVENT_PAYLOAD_TRAIT = Trait(id=ShapeID("smithy.api#eventPayload"))
 ERROR_TRAIT = Trait(id=ShapeID("smithy.api#error"), value="client")
diff --git a/packages/aws-event-stream/tests/unit/_private/test_deserializers.py b/packages/aws-event-stream/tests/unit/_private/test_deserializers.py
@@ -4,16 +4,15 @@
 from typing import Any
 
 import pytest
-from smithy_core.aio.types import AsyncBytesReader
-from smithy_core.deserializers import DeserializeableShape
-from smithy_json import JSONCodec
-
 from aws_event_stream._private.deserializers import (
     AWSAsyncEventReceiver,
     EventDeserializer,
 )
 from aws_event_stream.events import Event, EventMessage
 from aws_event_stream.exceptions import UnmodeledEventError
+from smithy_core.aio.types import AsyncBytesReader
+from smithy_core.deserializers import DeserializeableShape
+from smithy_json import JSONCodec
 
 from . import (
     EVENT_STREAM_SERDE_CASES,
diff --git a/packages/aws-event-stream/tests/unit/_private/test_serializers.py b/packages/aws-event-stream/tests/unit/_private/test_serializers.py
@@ -1,11 +1,10 @@
 # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 # SPDX-License-Identifier: Apache-2.0
 import pytest
-from smithy_core.serializers import SerializeableShape
-from smithy_json import JSONCodec
-
 from aws_event_stream._private.serializers import EventSerializer
 from aws_event_stream.events import EventMessage
+from smithy_core.serializers import SerializeableShape
+from smithy_json import JSONCodec
 
 from . import EVENT_STREAM_SERDE_CASES, INITIAL_REQUEST_CASE, INITIAL_RESPONSE_CASE
 
diff --git a/packages/aws-event-stream/tests/unit/test_events.py b/packages/aws-event-stream/tests/unit/test_events.py
@@ -6,8 +6,6 @@
 from io import BytesIO
 
 import pytest
-from smithy_core.aio.types import AsyncBytesReader
-
 from aws_event_stream.events import (
     MAX_HEADER_VALUE_BYTE_LENGTH,
     MAX_HEADERS_LENGTH,
@@ -31,6 +29,7 @@
     InvalidIntegerValue,
     InvalidPayloadLength,
 )
+from smithy_core.aio.types import AsyncBytesReader
 
 EMPTY_MESSAGE = (
     (
diff --git a/packages/smithy-core/tests/unit/aio/test_types.py b/packages/smithy-core/tests/unit/aio/test_types.py
@@ -5,7 +5,6 @@
 from typing import Self
 
 import pytest
-
 from smithy_core.aio.types import (
     AsyncBytesProvider,
     AsyncBytesReader,
diff --git a/packages/smithy-core/tests/unit/test_documents.py b/packages/smithy-core/tests/unit/test_documents.py
@@ -5,7 +5,6 @@
 from typing import Any, Self, cast
 
 import pytest
-
 from smithy_core.deserializers import ShapeDeserializer
 from smithy_core.documents import (
     Document,
diff --git a/packages/smithy-core/tests/unit/test_identity.py b/packages/smithy-core/tests/unit/test_identity.py
@@ -4,7 +4,6 @@
 
 import pytest
 from freezegun import freeze_time
-
 from smithy_core.identity import Identity
 
 
diff --git a/packages/smithy-core/tests/unit/test_retries.py b/packages/smithy-core/tests/unit/test_retries.py
@@ -2,7 +2,6 @@
 #  SPDX-License-Identifier: Apache-2.0
 
 import pytest
-
 from smithy_core.exceptions import SmithyRetryException
 from smithy_core.interfaces.retries import RetryErrorInfo, RetryErrorType
 from smithy_core.retries import ExponentialBackoffJitterType as EBJT
diff --git a/packages/smithy-core/tests/unit/test_schemas.py b/packages/smithy-core/tests/unit/test_schemas.py
@@ -1,7 +1,6 @@
 from dataclasses import replace
 
 import pytest
-
 from smithy_core.exceptions import ExpectationNotMetException
 from smithy_core.schemas import Schema
 from smithy_core.shapes import ShapeID, ShapeType
diff --git a/packages/smithy-core/tests/unit/test_shapes.py b/packages/smithy-core/tests/unit/test_shapes.py
@@ -1,5 +1,4 @@
 import pytest
-
 from smithy_core.exceptions import ExpectationNotMetException, SmithyException
 from smithy_core.shapes import ShapeID
 
diff --git a/packages/smithy-core/tests/unit/test_types.py b/packages/smithy-core/tests/unit/test_types.py
@@ -5,7 +5,6 @@
 from datetime import datetime, timezone
 
 import pytest
-
 from smithy_core.exceptions import ExpectationNotMetException
 from smithy_core.types import JsonBlob, JsonString, TimestampFormat
 
diff --git a/packages/smithy-core/tests/unit/test_uri.py b/packages/smithy-core/tests/unit/test_uri.py
@@ -1,7 +1,6 @@
 #  Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 #  SPDX-License-Identifier: Apache-2.0
 import pytest
-
 from smithy_core import URI, HostType
 from smithy_core.exceptions import SmithyException
 
diff --git a/packages/smithy-core/tests/unit/test_utils.py b/packages/smithy-core/tests/unit/test_utils.py
@@ -11,7 +11,6 @@
 from unittest.mock import Mock
 
 import pytest
-
 from smithy_core.exceptions import ExpectationNotMetException
 from smithy_core.utils import (
     ensure_utc,
diff --git a/packages/smithy-http/src/smithy_http/aio/restjson.py b/packages/smithy-http/src/smithy_http/aio/restjson.py
@@ -5,10 +5,12 @@
 from smithy_core.documents import DocumentValue
 from smithy_core.utils import expect_type
 
-from ..restjson import _REST_JSON_CODE_HEADER  # pyright: ignore[reportPrivateUsage]
-from ..restjson import _REST_JSON_CODE_KEYS  # pyright: ignore[reportPrivateUsage]
-from ..restjson import _REST_JSON_MESSAGE_KEYS  # pyright: ignore[reportPrivateUsage]
-from ..restjson import RestJsonErrorInfo
+from ..restjson import (
+    _REST_JSON_CODE_HEADER,  # pyright: ignore[reportPrivateUsage]
+    _REST_JSON_CODE_KEYS,  # pyright: ignore[reportPrivateUsage]
+    _REST_JSON_MESSAGE_KEYS,  # pyright: ignore[reportPrivateUsage]
+    RestJsonErrorInfo,
+)
 from .interfaces import HTTPResponse
 
 
diff --git a/packages/smithy-http/tests/integration/aio/conftest.py b/packages/smithy-http/tests/integration/aio/conftest.py
@@ -4,7 +4,6 @@
 import pytest
 from smithy_core import URI
 from smithy_core.aio.utils import async_list
-
 from smithy_http import Field, Fields
 from smithy_http.aio import HTTPRequest
 
diff --git a/packages/smithy-http/tests/integration/aio/test_aiohttp.py b/packages/smithy-http/tests/integration/aio/test_aiohttp.py
@@ -1,7 +1,6 @@
 #  Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 #  SPDX-License-Identifier: Apache-2.0
 import pytest
-
 from smithy_http.aio import HTTPRequest
 from smithy_http.aio.aiohttp import AIOHTTPClient, AIOHTTPClientConfig
 
diff --git a/packages/smithy-http/tests/integration/aio/test_crt.py b/packages/smithy-http/tests/integration/aio/test_crt.py
@@ -1,7 +1,6 @@
 #  Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 #  SPDX-License-Identifier: Apache-2.0
 import pytest
-
 from smithy_http.aio import HTTPRequest
 from smithy_http.aio.crt import AWSCRTHTTPClient, AWSCRTHTTPClientConfig
 
diff --git a/packages/smithy-http/tests/unit/aio/auth/test_apikey.py b/packages/smithy-http/tests/unit/aio/auth/test_apikey.py
@@ -8,7 +8,6 @@
 from smithy_core.aio.interfaces.identity import IdentityResolver
 from smithy_core.exceptions import SmithyIdentityException
 from smithy_core.interfaces.identity import IdentityProperties
-
 from smithy_http import Field, Fields
 from smithy_http.aio import HTTPRequest
 from smithy_http.aio.auth.apikey import (
diff --git a/packages/smithy-http/tests/unit/aio/test_endpoints.py b/packages/smithy-http/tests/unit/aio/test_endpoints.py
@@ -1,7 +1,6 @@
 #  Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 #  SPDX-License-Identifier: Apache-2.0
 from smithy_core import URI
-
 from smithy_http import Fields
 from smithy_http.aio.endpoints import StaticEndpointResolver
 from smithy_http.endpoints import StaticEndpointParams
diff --git a/packages/smithy-http/tests/unit/aio/test_http.py b/packages/smithy-http/tests/unit/aio/test_http.py
@@ -2,7 +2,6 @@
 #  SPDX-License-Identifier: Apache-2.0
 from smithy_core import URI
 from smithy_core.aio.utils import async_list
-
 from smithy_http import Field, Fields
 from smithy_http.aio import HTTPRequest, HTTPResponse
 
diff --git a/packages/smithy-http/tests/unit/aio/test_restjson.py b/packages/smithy-http/tests/unit/aio/test_restjson.py
@@ -7,7 +7,6 @@
 import pytest
 from smithy_core.aio.utils import async_list
 from smithy_core.documents import DocumentValue
-
 from smithy_http import tuples_to_fields
 from smithy_http.aio import HTTPResponse
 from smithy_http.aio.restjson import parse_rest_json_error_info
diff --git a/packages/smithy-http/tests/unit/test_fields.py b/packages/smithy-http/tests/unit/test_fields.py
@@ -5,7 +5,6 @@
 # mypy: allow-incomplete-defs
 
 import pytest
-
 from smithy_http import Field, Fields
 from smithy_http.interfaces import FieldPosition
 
diff --git a/packages/smithy-http/tests/unit/test_utils.py b/packages/smithy-http/tests/unit/test_utils.py
@@ -2,7 +2,6 @@
 #  SPDX-License-Identifier: Apache-2.0
 import pytest
 from smithy_core.exceptions import SmithyException
-
 from smithy_http.utils import join_query_params, split_header
 
 
diff --git a/packages/smithy-json/tests/unit/__init__.py b/packages/smithy-json/tests/unit/__init__.py
@@ -19,7 +19,6 @@
 from smithy_core.serializers import ShapeSerializer
 from smithy_core.shapes import ShapeID, ShapeType
 from smithy_core.traits import Trait
-
 from smithy_json._private.traits import JSON_NAME, TIMESTAMP_FORMAT
 
 SPARSE_TRAIT = Trait(id=ShapeID("smithy.api#sparse"))
diff --git a/packages/smithy-json/tests/unit/test_deserializers.py b/packages/smithy-json/tests/unit/test_deserializers.py
@@ -14,7 +14,6 @@
     STRING,
     TIMESTAMP,
 )
-
 from smithy_json import JSONCodec
 
 from . import (
diff --git a/packages/smithy-json/tests/unit/test_serializers.py b/packages/smithy-json/tests/unit/test_serializers.py
@@ -14,7 +14,6 @@
     STRING,
     TIMESTAMP,
 )
-
 from smithy_json import JSONCodec
 
 from . import (
diff --git a/pyproject.toml b/pyproject.toml
@@ -50,8 +50,8 @@ target-version = "py312"
 # perhaps in the future: N, PYI, TC, TID
 # probably not, a lot of work: DOC, D, PL, TRY
 
-# TODO: I, T, UP
-select = [ "ASYNC", "E1", "E4", "E7", "E9", "F", "FURB", "G", "LOG", "S" ]
+# TODO: T, UP
+select = [ "ASYNC", "E1", "E4", "E7", "E9", "F", "FURB", "G", "I", "LOG", "S" ]
 exclude = [ "packages/smithy-core/src/smithy_core/rfc3986.py" ]
 
 [tool.ruff.lint.per-file-ignores]

Original file line number	Diff line number	Diff line change
`@@ -6,8 +6,6 @@`
`6`	`6`	`from io import BytesIO`
`7`	`7`
`8`	`8`	`import pytest`
`9`		`-from smithy_core.aio.types import AsyncBytesReader`
`10`		`-`
`11`	`9`	`from aws_event_stream.events import (`
`12`	`10`	`MAX_HEADER_VALUE_BYTE_LENGTH,`
`13`	`11`	`MAX_HEADERS_LENGTH,`
`@@ -31,6 +29,7 @@`
`31`	`29`	`InvalidIntegerValue,`
`32`	`30`	`InvalidPayloadLength,`
`33`	`31`	`)`
	`32`	`+from smithy_core.aio.types import AsyncBytesReader`
`34`	`33`
`35`	`34`	`EMPTY_MESSAGE = (`
`36`	`35`	`(`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`import pytest`
`2`		`-`
`3`	`2`	`from smithy_core.exceptions import ExpectationNotMetException, SmithyException`
`4`	`3`	`from smithy_core.shapes import ShapeID`
`5`	`4`