Skip to content

Lock Smithy to a static version #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Lock Smithy to a static version #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions codegen/gradle.properties
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion codegen/settings.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@ pluginManagement {
}
val smithyGradleVersion: String by settings
plugins {
id("software.amazon.smithy.gradle.smithy-base").version(smithyGradleVersion)
id("software.amazon.smithy.gradle.smithy-base").version("1.1.0")
}
}
16 changes: 1 addition & 15 deletions codegen/smithy-aws-python-codegen/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,7 @@ description = "Generates AWS Python code from Smithy models"
extra["displayName"] = "Smithy :: AWS :: Python :: Codegen"
extra["moduleName"] = "software.amazon.smithy.aws.python.codegen"

val smithyVersion: String by project

buildscript {
val smithyVersion: String by project

repositories {
mavenLocal()
mavenCentral()
}
dependencies {
"classpath"("software.amazon.smithy:smithy-cli:$smithyVersion")
}
}

dependencies {
implementation(project(":smithy-python-codegen"))
implementation("software.amazon.smithy:smithy-aws-traits:$smithyVersion")
implementation("software.amazon.smithy:smithy-aws-traits:1.52.0")
}
6 changes: 2 additions & 4 deletions codegen/smithy-python-codegen-test/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,8 @@ repositories {
mavenCentral()
}

val smithyVersion: String by project

dependencies {
implementation(project(":smithy-python-codegen"))
implementation("software.amazon.smithy:smithy-waiters:$smithyVersion")
implementation("software.amazon.smithy:smithy-protocol-test-traits:$smithyVersion")
implementation("software.amazon.smithy:smithy-waiters:1.52.0")
implementation("software.amazon.smithy:smithy-protocol-test-traits:1.52.0")
}
22 changes: 4 additions & 18 deletions codegen/smithy-python-codegen/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,10 @@ description = "Generates Python code from Smithy models"
extra["displayName"] = "Smithy :: Python :: Codegen"
extra["moduleName"] = "software.amazon.smithy.python.codegen"

val smithyVersion: String by project

buildscript {
val smithyVersion: String by project

repositories {
mavenLocal()
mavenCentral()
}
dependencies {
"classpath"("software.amazon.smithy:smithy-cli:$smithyVersion")
}
}

dependencies {
api("software.amazon.smithy:smithy-codegen-core:$smithyVersion")
implementation("software.amazon.smithy:smithy-waiters:$smithyVersion")
implementation("software.amazon.smithy:smithy-protocol-test-traits:$smithyVersion")
api("software.amazon.smithy:smithy-codegen-core:1.52.0")
implementation("software.amazon.smithy:smithy-waiters:1.52.0")
implementation("software.amazon.smithy:smithy-protocol-test-traits:1.52.0")
// We have this because we're using RestJson1 as a 'generic' protocol.
implementation("software.amazon.smithy:smithy-aws-traits:$smithyVersion")
implementation("software.amazon.smithy:smithy-aws-traits:1.52.0")
}
4 changes: 1 addition & 3 deletions codegen/smithy-python-protocol-test/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@ repositories {
mavenCentral()
}

val smithyVersion: String by project

dependencies {
implementation(project(":smithy-python-codegen"))
implementation("software.amazon.smithy:smithy-aws-protocol-tests:$smithyVersion")
implementation("software.amazon.smithy:smithy-aws-protocol-tests:1.52.0")
}
Loading