diff --git a/codegen/smithy-python-codegen/src/main/java/software/amazon/smithy/python/codegen/CodegenUtils.java b/codegen/smithy-python-codegen/src/main/java/software/amazon/smithy/python/codegen/CodegenUtils.java index 80571f001..b65bd047b 100644 --- a/codegen/smithy-python-codegen/src/main/java/software/amazon/smithy/python/codegen/CodegenUtils.java +++ b/codegen/smithy-python-codegen/src/main/java/software/amazon/smithy/python/codegen/CodegenUtils.java @@ -106,8 +106,8 @@ public static Symbol getPluginSymbol(PythonSettings settings) { public static Symbol getServiceError(PythonSettings settings) { return Symbol.builder() .name("ServiceError") - .namespace(format("%s.errors", settings.moduleName()), ".") - .definitionFile(format("./%s/errors.py", settings.moduleName())) + .namespace(format("%s.models", settings.moduleName()), ".") + .definitionFile(format("./%s/models.py", settings.moduleName())) .build(); } @@ -123,8 +123,8 @@ public static Symbol getServiceError(PythonSettings settings) { public static Symbol getApiError(PythonSettings settings) { return Symbol.builder() .name("ApiError") - .namespace(format("%s.errors", settings.moduleName()), ".") - .definitionFile(format("./%s/errors.py", settings.moduleName())) + .namespace(format("%s.models", settings.moduleName()), ".") + .definitionFile(format("./%s/models.py", settings.moduleName())) .build(); } @@ -140,8 +140,8 @@ public static Symbol getApiError(PythonSettings settings) { public static Symbol getUnknownApiError(PythonSettings settings) { return Symbol.builder() .name("UnknownApiError") - .namespace(format("%s.errors", settings.moduleName()), ".") - .definitionFile(format("./%s/errors.py", settings.moduleName())) + .namespace(format("%s.models", settings.moduleName()), ".") + .definitionFile(format("./%s/models.py", settings.moduleName())) .build(); } diff --git a/codegen/smithy-python-codegen/src/main/java/software/amazon/smithy/python/codegen/StructureGenerator.java b/codegen/smithy-python-codegen/src/main/java/software/amazon/smithy/python/codegen/StructureGenerator.java index 6703ab5f1..b7eea5041 100644 --- a/codegen/smithy-python-codegen/src/main/java/software/amazon/smithy/python/codegen/StructureGenerator.java +++ b/codegen/smithy-python-codegen/src/main/java/software/amazon/smithy/python/codegen/StructureGenerator.java @@ -147,9 +147,12 @@ class $1L($2T): ${7C|} + ${8C|} + """, symbol.getName(), apiError, code, fault, writer.consumer(w -> writeClassDocs(true)), writer.consumer(w -> writeProperties()), + writer.consumer(w -> generateSerializeMethod()), writer.consumer(w -> generateDeserializeMethod())); } diff --git a/codegen/smithy-python-codegen/src/main/java/software/amazon/smithy/python/codegen/SymbolVisitor.java b/codegen/smithy-python-codegen/src/main/java/software/amazon/smithy/python/codegen/SymbolVisitor.java index ad6c64a0f..b57dc131d 100644 --- a/codegen/smithy-python-codegen/src/main/java/software/amazon/smithy/python/codegen/SymbolVisitor.java +++ b/codegen/smithy-python-codegen/src/main/java/software/amazon/smithy/python/codegen/SymbolVisitor.java @@ -330,8 +330,7 @@ private Symbol genericEnum(Shape shape) { @Override public Symbol structureShape(StructureShape shape) { String name = getDefaultShapeName(shape); - var file = shape.hasTrait(ErrorTrait.class) ? "errors" : SHAPES_FILE; - return createGeneratedSymbolBuilder(shape, name, file).build(); + return createGeneratedSymbolBuilder(shape, name, SHAPES_FILE).build(); } @Override