Skip to content

Write error trait to schema #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Write error trait to schema #348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...y-python-codegen/src/main/java/software/amazon/smithy/python/codegen/SchemaGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import software.amazon.smithy.model.shapes.ShapeId;
import software.amazon.smithy.model.traits.DocumentationTrait;
import software.amazon.smithy.model.traits.EnumTrait;
import software.amazon.smithy.model.traits.ErrorTrait;
import software.amazon.smithy.model.traits.UnitTypeTrait;
import software.amazon.smithy.model.traits.synthetic.SyntheticEnumTrait;
import software.amazon.smithy.utils.CaseUtils;
Expand All @@ -36,9 +35,10 @@
final class SchemaGenerator implements Consumer<Shape> {
private static final Logger LOGGER = Logger.getLogger(SchemaGenerator.class.getName());

// Filter out traits that already exist as generated parts of the class, such as documentation.
// Filter out traits that would overly bloat the definition, which are already part of the
// class, such as documentation.
private static final Set<ShapeId> DEFAULT_TRAIT_FILTER = Set.of(
DocumentationTrait.ID, ErrorTrait.ID, EnumTrait.ID, SyntheticEnumTrait.ID
DocumentationTrait.ID, EnumTrait.ID, SyntheticEnumTrait.ID
);

private static final Symbol UNIT_SYMBOL = Symbol.builder()
Expand Down
Loading