Safely copy crt clients #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The request pipeline currently deepcopies the config since it can be mutated by plugins. This was causing issues when copying a CRT client, which has un-copiable components to it. This implements the deepcopy method to behave better. It may be necessary in the future to either remove the deepcopy, or modify this implementation to violate the intent of a deepcopy somewhat. I'm a bit concerned about not sharing the connection pool.
nateprewitt
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request pipeline currently deepcopies the config since it can be mutated by plugins. This was causing issues when copying a CRT client, which has un-copiable components to it. This implements the deepcopy method to behave better.
It may be necessary in the future to either remove the deepcopy, or modify this implementation to violate the intent of a deepcopy somewhat. I'm a bit concerned about not sharing the connection pool.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.