Rewind bodies before retrying #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates requests to use seekable bodies wherever possible so that they can be retried.
nateprewitt
requested changes
Jan 7, 2025
...ithy-python-codegen/src/main/java/software/amazon/smithy/python/codegen/ClientGenerator.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Nate Prewitt <[email protected]>
nateprewitt
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bodies weren't being rewound before a retry, which was causing some issues. Notably asyncio would hang forever awaiting the number of bytes we'd already declared in the content-length. But in general it just meant retries didn't work at all.
This updates the serializer to use a seekable stream wherever possible for non-streaming bodies. For streaming blobs, this was already being done where necessary.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.