Skip to content

Commit 200335b

Browse files
authored
Merge branch 'main' into landonxjames/smithy152
2 parents 19d76ca + 4b66264 commit 200335b

File tree

34 files changed

+1000
-602
lines changed

34 files changed

+1000
-602
lines changed

.changelog/1729271936.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
---
2+
applies_to:
3+
- aws-sdk-rust
4+
authors:
5+
- ysaito1001
6+
references:
7+
- smithy-rs#3883
8+
breaking: false
9+
new_feature: false
10+
bug_fix: false
11+
---
12+
Client SDKs built with the `awsQueryCompatible` trait now include the `x-amzn-query-mode` header. This header signals the service that the clients are operating in compatible mode.

.github/workflows/ci.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,9 @@ jobs:
6565
with:
6666
path: smithy-rs
6767
ref: ${{ inputs.git_ref }}
68+
# `generate-smithy-rs-release` requires access to previous tags to determine if a numerical suffix is needed
69+
# to make the release tag unique
70+
fetch-depth: 0
6871
# The models from aws-sdk-rust are needed to generate the full SDK for CI
6972
- uses: actions/checkout@v4
7073
with:

.github/workflows/release-scripts/create-release.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const assert = require("assert");
1010
const fs = require("fs");
1111

1212
const smithy_rs_repo = {
13-
owner: "awslabs",
13+
owner: "smithy-lang",
1414
repo: "smithy-rs",
1515
};
1616

.github/workflows/release.yml

Lines changed: 24 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -181,12 +181,18 @@ jobs:
181181
ref: ${{ inputs.commit_sha }}
182182
path: smithy-rs
183183
token: ${{ secrets.RELEASE_AUTOMATION_BOT_PAT }}
184+
fetch-depth: 0
184185
- name: Generate release artifacts
185186
uses: ./smithy-rs/.github/actions/docker-build
186187
with:
187188
action: generate-smithy-rs-release
188189
- name: Download all artifacts
189190
uses: ./smithy-rs/.github/actions/download-all-artifacts
191+
# This step is not idempotent, as it pushes release artifacts to the `smithy-rs-release-1.x.y` branch. However,
192+
# if this step succeeds but a subsequent step fails, retrying the release workflow is "safe" in that it does not
193+
# create any inconsistent states; this step would simply fail because the release branch would be ahead of `main`
194+
# due to previously pushed artifacts.
195+
# To successfully retry a release, revert the commits in the release branch that pushed the artifacts.
190196
- name: Push smithy-rs changes
191197
shell: bash
192198
working-directory: smithy-rs-release/smithy-rs
@@ -202,7 +208,7 @@ jobs:
202208
# to retry a release action execution that failed due to a transient issue.
203209
# In that case, we expect the commit to be releasable as-is, i.e. the changelog should have already
204210
# been processed.
205-
git fetch --unshallow
211+
git fetch
206212
if [[ "${DRY_RUN}" == "true" ]]; then
207213
# During dry-runs, "git push" without "--force" can fail if smithy-rs-release-x.y.z-preview is behind
208214
# smithy-rs-release-x.y.z, but that does not matter much during dry-runs.
@@ -214,18 +220,7 @@ jobs:
214220
fi
215221
fi
216222
echo "commit_sha=$(git rev-parse HEAD)" > $GITHUB_OUTPUT
217-
- name: Tag release
218-
uses: actions/github-script@v7
219-
with:
220-
github-token: ${{ secrets.RELEASE_AUTOMATION_BOT_PAT }}
221-
script: |
222-
const createReleaseScript = require("./smithy-rs/.github/workflows/release-scripts/create-release.js");
223-
await createReleaseScript({
224-
github,
225-
isDryRun: ${{ inputs.dry_run }},
226-
releaseManifestPath: "smithy-rs-release/smithy-rs-release-manifest.json",
227-
releaseCommitish: "${{ steps.push-changelog.outputs.commit_sha }}"
228-
});
223+
# This step is idempotent; the `publisher` will not publish a crate if the version is already published on crates.io.
229224
- name: Publish to crates.io
230225
shell: bash
231226
working-directory: smithy-rs-release/crates-to-publish
@@ -247,7 +242,23 @@ jobs:
247242
else
248243
publisher publish -y --location .
249244
fi
245+
# This step is not idempotent and MUST be performed last, as it will generate a new release in the `smithy-rs`
246+
# repository with the release tag that is always unique and has an increasing numerical suffix.
247+
- name: Tag release
248+
uses: actions/github-script@v7
249+
with:
250+
github-token: ${{ secrets.RELEASE_AUTOMATION_BOT_PAT }}
251+
script: |
252+
const createReleaseScript = require("./smithy-rs/.github/workflows/release-scripts/create-release.js");
253+
await createReleaseScript({
254+
github,
255+
isDryRun: ${{ inputs.dry_run }},
256+
releaseManifestPath: "smithy-rs-release/smithy-rs-release-manifest.json",
257+
releaseCommitish: "${{ steps.push-changelog.outputs.commit_sha }}"
258+
});
250259
260+
# If this step fails for any reason, there's no need to retry the release workflow, as this step is auxiliary
261+
# and the release itself was successful. Instead, manually trigger `backport-pull-request.yml`.
251262
open-backport-pull-request:
252263
name: Open backport pull request to merge the release branch back to main
253264
needs:

aws/rust-runtime/Cargo.lock

Lines changed: 23 additions & 34 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

aws/rust-runtime/aws-config/Cargo.lock

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

aws/rust-runtime/aws-inlineable/Cargo.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ http_1x = ["dep:http-1x", "dep:http-body-1x", "aws-smithy-runtime-api/http-1x"]
1818
aws-credential-types = { path = "../aws-credential-types" }
1919
aws-runtime = { path = "../aws-runtime", features = ["http-02x"] }
2020
aws-sigv4 = { path = "../aws-sigv4" }
21+
aws-types = { path = "../aws-types" }
2122
aws-smithy-async = { path = "../../../rust-runtime/aws-smithy-async", features = ["rt-tokio"] }
2223
aws-smithy-checksums = { path = "../../../rust-runtime/aws-smithy-checksums" }
2324
aws-smithy-http = { path = "../../../rust-runtime/aws-smithy-http" }
@@ -37,8 +38,10 @@ ring = "0.17.5"
3738
sha2 = "0.10"
3839
tokio = "1.23.1"
3940
tracing = "0.1"
41+
url = "2.5.2"
4042

4143
[dev-dependencies]
44+
aws-credential-types = { path = "../aws-credential-types", features = ["test-util"] }
4245
aws-smithy-async = { path = "../../../rust-runtime/aws-smithy-async", features = ["test-util"] }
4346
aws-smithy-http = { path = "../../../rust-runtime/aws-smithy-http", features = ["rt-tokio"] }
4447
aws-smithy-runtime-api = { path = "../../../rust-runtime/aws-smithy-runtime-api", features = ["test-util"] }

aws/rust-runtime/aws-inlineable/external-types.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
allowed_external_types = [
2-
"aws_credential_types::provider::credentials::ProvideCredentials",
2+
"aws_types::*",
3+
"aws_credential_types::*",
34
"aws_smithy_http::*",
45
"aws_smithy_runtime_api::*",
56

aws/rust-runtime/aws-inlineable/src/lib.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,3 +65,5 @@ pub mod s3_expires_interceptor;
6565
/// allow docs to work
6666
#[derive(Debug)]
6767
pub struct Client;
68+
69+
pub mod rds_auth_token;

0 commit comments

Comments
 (0)