Skip to content

Commit 2eb2c63

Browse files
authored
Disable smoke tests code generation (#3864)
## Motivation and Context `SmokeTestsDecorator` needs more test cases for it to be used reliably. Till #3863 has been resolved, we will stop code generating service smoke tests. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
1 parent 796ec3a commit 2eb2c63

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/AwsCodegenDecorator.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,8 @@ val DECORATORS: List<ClientCodegenDecorator> =
6464
TokenProvidersDecorator(),
6565
ServiceEnvConfigDecorator(),
6666
HttpRequestCompressionDecorator(),
67-
SmokeTestsDecorator(),
67+
// TODO(https://github.com/smithy-lang/smithy-rs/issues/3863): Comment in once the issue has been resolved
68+
// SmokeTestsDecorator(),
6869
),
6970
// S3 needs `AwsErrorCodeClassifier` to handle an `InternalError` as a transient error. We need to customize
7071
// that behavior for S3 in a way that does not conflict with the globally applied `RetryClassifierDecorator`.

aws/sdk-codegen/src/test/kotlin/software/amazon/smithy/rustsdk/SmokeTestsDecoratorTest.kt

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -198,22 +198,26 @@ class SmokeTestsDecoratorTest {
198198

199199
@Test
200200
fun smokeTestSdkCodegen() {
201-
testSmokeTestsWithModel(model)
201+
// TODO(https://github.com/smithy-lang/smithy-rs/issues/3863): Comment in once the issue has been resolved
202+
// testSmokeTestsWithModel(model)
202203
}
203204

204205
@Test
205206
fun smokeTestSdkCodegenNoDualStack() {
206-
testSmokeTestsWithModel(modelWithNoDualStack)
207+
// TODO(https://github.com/smithy-lang/smithy-rs/issues/3863): Comment in once the issue has been resolved
208+
// testSmokeTestsWithModel(modelWithNoDualStack)
207209
}
208210

209211
@Test
210212
fun smokeTestSdkCodegenNoFips() {
211-
testSmokeTestsWithModel(modelWithNoFips)
213+
// TODO(https://github.com/smithy-lang/smithy-rs/issues/3863): Comment in once the issue has been resolved
214+
// testSmokeTestsWithModel(modelWithNoFips)
212215
}
213216

214217
@Test
215218
fun smokeTestSdkCodegenNeitherBuiltIn() {
216-
testSmokeTestsWithModel(modelWithNeitherBuiltIn)
219+
// TODO(https://github.com/smithy-lang/smithy-rs/issues/3863): Comment in once the issue has been resolved
220+
// testSmokeTestsWithModel(modelWithNeitherBuiltIn)
217221
}
218222

219223
fun testSmokeTestsWithModel(model: Model) {

0 commit comments

Comments
 (0)