Bump Smithy to 1.67.0 (#4533)

## Motivation and Context
P382257849

## Description
Changes on the client side:
- [x] Remove extra rest json tests that are officially part of Smithy
protocol tests in 1.64.0
- [x] Filter out newly added model in `SmithyTypesPubUseExtraTest.kt`
that would otherwise defeat the purpose of the test

Changes on the server side:
- [x] Address errors related to server's constraint types
(#4506)
- [x] #4535
- [x] #4537 

## Testing
- CI

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Co-authored-by: Fahad Zubair <fahadzubair@gmail.com>
Co-authored-by: Fahad Zubair <fahadzub@amazon.com>

Author: 3 people

codegen-core/common-test-models/rest-json-extras.smithy

@@ -66,7 +66,6 @@ service RestJsonExtras {
         CaseInsensitiveErrorOperation,
         EmptyStructWithContentOnWireOp,
         QueryPrecedence,
-        HttpQueryParamsOnlyOperation,
     ],
     errors: [ExtraError]
 }
@@ -351,46 +350,3 @@ structure EmptyStructWithContentOnWireOpOutput {
 operation EmptyStructWithContentOnWireOp {
     output: EmptyStructWithContentOnWireOpOutput,
 }
-
-@http(uri: "/http-query-params-only", method: "GET")
-@httpRequestTests([
-    {
-        id: "HttpQueryParamsOnlyRequest",
-        documentation: "Test that httpQueryParams are included in request when no other query parameters exist",
-        protocol: "aws.protocols#restJson1",
-        method: "GET",
-        uri: "/http-query-params-only",
-        queryParams: ["shouldExpandRoles=true", "shouldShowOnlyAuthForThisDocument=false"],
-        params: {
-            queryMap: {
-                "shouldExpandRoles": "true",
-                "shouldShowOnlyAuthForThisDocument": "false"
-            }
-        },
-        appliesTo: "client",
-    },
-    {
-        id: "HttpQueryParamsOnlyEmptyRequest",
-        documentation: "Test that empty httpQueryParams map results in no query parameters",
-        protocol: "aws.protocols#restJson1",
-        method: "GET",
-        uri: "/http-query-params-only",
-        params: {
-            queryMap: {}
-        },
-        appliesTo: "client",
-    }
-])
-operation HttpQueryParamsOnlyOperation {
-    input: HttpQueryParamsOnlyInput,
-}
-
-structure HttpQueryParamsOnlyInput {
-    @httpQueryParams
-    queryMap: QueryMap,
-}
-
-map QueryMap {
-    key: String,
-    value: String,
-}

codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/customizations/AllowLintsCustomization.kt

@@ -47,6 +47,8 @@ private val allowedClippyLints =
         "result_large_err",
         // Difficult to avoid in generated code
         "unnecessary_map_on_constructor",
+        // Introduced by Python server codegen but needs to be suppressed for regular codegen (https://github.com/smithy-lang/smithy-rs/pull/4537)
+        "useless_conversion",
         // Service models can specify a date, such as 2024-01-08, as the "since" date for deprecation.
         "deprecated_semver",
     )

codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/protocols/serialize/EventStreamMarshallerGenerator.kt

@@ -265,7 +265,7 @@ open class EventStreamMarshallerGenerator(
             is BlobShape -> "ByteArray($inputName.into_inner().into())"
             is EnumShape -> "String($inputName.to_string().into())"
             is StringShape -> "String($inputName.into())"
-            is TimestampShape -> "Timestamp($inputName)"
+            is TimestampShape -> "Timestamp($inputName.into())"
             else -> throw IllegalStateException("unsupported event stream header shape type: $target")
         }
 

codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/testutil/TestHelpers.kt

@@ -150,14 +150,15 @@ fun String.asSmithyModel(
     sourceLocation: String? = null,
     smithyVersion: String = SMITHY_VERSION,
     disableValidation: Boolean = false,
+    additionalDeniedModels: Array<String> = emptyArray(),
 ): Model {
     val processed = letIf(!this.trimStart().startsWith("\$version")) { "\$version: ${smithyVersion.dq()}\n$it" }
     val denyModelsContaining =
         arrayOf(
             // If Smithy protocol test models are in our classpath, don't load them, since they are fairly large and we
             // almost never need them.
             "smithy-protocol-tests",
-        )
+        ) + additionalDeniedModels
     val urls =
         ModelDiscovery.findModels().filter { modelUrl ->
             denyModelsContaining.none {

codegen-core/src/test/kotlin/software/amazon/smithy/rust/codegen/core/smithy/customizations/SmithyTypesPubUseExtraTest.kt

@@ -47,7 +47,11 @@ class SmithyTypesPubUseExtraTest {
                 input: SomeInput,
                 output: SomeOutput
             }
-        """.asSmithyModel()
+        """.asSmithyModel(
+            // Filters out models containing `smithy.test#EventHeaderValue` to avoid pulling in
+            // blob and timestamp types, which would defeat the purpose of this test.
+            additionalDeniedModels = arrayOf("smithy-protocol-test-traits"),
+        )
     }
 
     private fun initialize(model: Model): Pair<CodegenContext, RustCrate> {

gradle/libs.versions.toml

@@ -3,7 +3,7 @@ kotlin-version = "2.1.0"
 ktlint-version = "1.0.1"
 
 # codegen
-smithy-version = "1.63.0"
+smithy-version = "1.67.0"
 smithy-gradle-plugin-version = "1.3.0"
 
 # publishing

rust-runtime/Cargo.lock

@@ -373,6 +373,12 @@ impl From<aws_smithy_types::DateTime> for DateTime {
     }
 }
 
+impl From<DateTime> for aws_smithy_types::DateTime {
+    fn from(other: DateTime) -> aws_smithy_types::DateTime {
+        other.0
+    }
+}
+
 impl Deref for DateTime {
     type Target = aws_smithy_types::DateTime;