Restore deny warning flags

Author: Fahad Zubair

buildSrc/src/main/kotlin/CodegenTestCommon.kt

@@ -286,7 +286,6 @@ fun Project.registerGenerateCargoConfigTomlTask(outputDir: File) {
         // is completed, warnings can be prohibited in rustdoc by setting `rustdocflags` to `-D warnings`.
         doFirst {
             outputDir.resolve(".cargo").mkdirs()
-            // TODO(MSRV1.82 follow-up): Restore `"--deny", "warnings"` once lints are fixed in the server runtime crates
             outputDir.resolve(".cargo/config.toml")
                 .writeText(
                     """

tools/ci-build/Dockerfile

@@ -206,9 +206,8 @@ ENV PATH=/opt/cargo/bin:$PATH \
     RUST_STABLE_VERSION=${rust_stable_version} \
     RUST_NIGHTLY_VERSION=${rust_nightly_version} \
     CARGO_INCREMENTAL=0 \
-    # TODO(MSRV1.82 follow-up): Restore them once lints are fixed in the server runtime crates
-    # RUSTDOCFLAGS="-D warnings" \
-    # RUSTFLAGS="-D warnings" \
+    RUSTDOCFLAGS="-D warnings" \
+    RUSTFLAGS="-D warnings" \
     LANG=en_US.UTF-8 \
     LC_ALL=en_US.UTF-8
 # SMITHY_RS_DOCKER_BUILD_IMAGE indicates to build scripts that they are being built inside of the Docker build image.

tools/ci-scripts/check-rust-runtimes

@@ -31,9 +31,7 @@ do
 
     echo -e "## ${C_YELLOW}Running 'cargo doc' on ${runtime_path}...${C_RESET}"
 
-    # TODO(MSRV1.82 follow-up): Restore `-Dwarnings` once lints are fixed in aws-smithy-http-server-python:
-    # "error: unexpected `cfg` condition name: `addr_of`"
-    RUSTDOCFLAGS="--cfg docsrs" cargo +"${RUST_NIGHTLY_VERSION}" doc --no-deps --document-private-items --all-features
+    RUSTDOCFLAGS="--cfg docsrs -Dwarnings" cargo +"${RUST_NIGHTLY_VERSION}" doc --no-deps --document-private-items --all-features
 
     echo -e "## ${C_YELLOW}Running 'cargo minimal-versions check' on ${runtime_path}...${C_RESET}"
     # Print out the cargo tree with minimal versions for easier debugging