remove sdkId transform by default (#4064)

## Motivation and Context
fixes awslabs/aws-sdk-rust#1252

## Description
The service ID we [were
setting](https://github.com/smithy-lang/smithy-rs/blob/5f7113f506f301296311ef637e40d226e0a6e548/aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/ServiceEnvConfigDecorator.kt#L27)
for service specific environment configuration was wrong. It was wrong
in two ways:

1. The
[sdkId](https://github.com/smithy-lang/smithy-rs/blob/7db3e9f08e422e386c56d5916c69ab495d739ee8/codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/util/Smithy.kt#L157)
extension we defined strips whitespace and lowercases the ID from the
model.
2. It also used `toSnakeCase()` which will not have the same effect as
internally that uses `splitOnWordBoundaries` which uses heuristics to
determine where a word boundary is and isn't restricted to spaces.

It looks like we've always applied this transform to sdkId from what I
can tell with the original use being to set the operation metadata for
the service name and it was carried through when making an extension.
This PR makes `sdkId()` return the ID from the model untouched. I think
this is the safest default as remembering when you can use the extension
vs not is error prone. Any required/desired transformations should be
done localized to where it's used. In this case the
`ServiceEnvConfigDecorator` doesn't need to transform sdkId as the
[runtime already does
it](https://github.com/smithy-lang/smithy-rs/blob/d1bbd018618da9ab8f8bdb1f27d9ec75c42d2505/aws/rust-runtime/aws-runtime/src/env_config.rs#L351)

## Testing

Tested on the bedrock-agent and bedrock-agent-runtime models described
in the issue

## Questions

There were only four uses of the `sdkId()` function I could find:
1. Operation metadata
2. Span names
3. Service env config
4. Default retry partition naming

I think this is a safe change though it will result in different log
output. Unclear if anyone would be predicating off service name if we
expose it anywhere (e.g. in an interceptor).

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] For changes to the AWS SDK, generated SDK code, or SDK runtime
crates, I have created a changelog entry Markdown file in the
`.changelog` directory, specifying "aws-sdk-rust" in the `applies_to`
key.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

Author: aajtodd

.changelog/1743016749.md

@@ -0,0 +1,12 @@
+---
+applies_to:
+- aws-sdk-rust
+authors:
+- aajtodd
+references:
+- aws-sdk-rust#1252
+breaking: false
+new_feature: false
+bug_fix: true
+---
+Fix service specific endpoint url keys

aws/rust-runtime/Cargo.lock

@@ -13,7 +13,6 @@ import software.amazon.smithy.rust.codegen.core.rustlang.rustTemplate
 import software.amazon.smithy.rust.codegen.core.smithy.RustCrate
 import software.amazon.smithy.rust.codegen.core.util.dq
 import software.amazon.smithy.rust.codegen.core.util.sdkId
-import software.amazon.smithy.rust.codegen.core.util.toSnakeCase
 
 class ServiceEnvConfigDecorator : ClientCodegenDecorator {
     override val name: String = "ServiceEnvConfigDecorator"
@@ -24,7 +23,7 @@ class ServiceEnvConfigDecorator : ClientCodegenDecorator {
         rustCrate: RustCrate,
     ) {
         val rc = codegenContext.runtimeConfig
-        val serviceId = codegenContext.serviceShape.sdkId().toSnakeCase().dq()
+        val serviceId = codegenContext.serviceShape.sdkId().dq()
         rustCrate.withModule(ClientRustModule.config) {
             Attribute.AllowDeadCode.render(this)
             rustTemplate(

aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/ServiceEnvConfigDecorator.kt

@@ -86,12 +86,12 @@ async fn metrics_have_expected_attributes() {
     let call_duration_attributes =
         extract_metric_attributes(&finished_metrics, "smithy.client.call.duration");
     assert!(call_duration_attributes[0].contains(&KeyValue::new("rpc.method", "GetObject")));
-    assert!(call_duration_attributes[0].contains(&KeyValue::new("rpc.service", "s3")));
+    assert!(call_duration_attributes[0].contains(&KeyValue::new("rpc.service", "S3")));
 
     let attempt_duration_attributes =
         extract_metric_attributes(&finished_metrics, "smithy.client.call.attempt.duration");
     assert!(attempt_duration_attributes[0].contains(&KeyValue::new("rpc.method", "GetObject")));
-    assert!(attempt_duration_attributes[0].contains(&KeyValue::new("rpc.service", "s3")));
+    assert!(attempt_duration_attributes[0].contains(&KeyValue::new("rpc.service", "S3")));
 
     // The attempt metric contains an attempt counter attribute that correctly increments
     assert!(attempt_duration_attributes

aws/sdk/Cargo.lock

@@ -23,8 +23,8 @@ async fn top_level_spans_exist_with_correct_attributes() {
     let ddb_top_level: fn() -> Box<dyn Visit + 'static> = || Box::new(DdbTestVisitor);
     let subscriber = tracing_subscriber::registry::Registry::default().with(TestLayer {
         visitor_factories: HashMap::from([
-            ("s3.GetObject", s3_top_level),
-            ("dynamodb.GetItem", ddb_top_level),
+            ("S3.GetObject", s3_top_level),
+            ("DynamoDB.GetItem", ddb_top_level),
         ]),
     });
     let _guard = tracing::subscriber::set_default(subscriber);
@@ -61,7 +61,7 @@ async fn all_expected_operation_spans_emitted_with_correct_nesting() {
     let subscriber = base_subscriber.with(AssertionsLayer::new(&assertion_registry));
     let _guard = tracing::subscriber::set_default(subscriber);
 
-    const OPERATION_NAME: &str = "s3.GetObject";
+    const OPERATION_NAME: &str = "S3.GetObject";
     const INVOKE: &str = "invoke";
     const TRY_OP: &str = "try_op";
     const TRY_ATTEMPT: &str = "try_attempt";
@@ -311,7 +311,7 @@ impl Visit for S3TestVisitor {
         if field_name == "rpc.system" {
             assert_eq!("aws-api".to_string(), field_value);
         } else if field_name == "rpc.service" {
-            assert_eq!("s3".to_string(), field_value);
+            assert_eq!("S3".to_string(), field_value);
         } else if field_name == "rpc.method" {
             assert_eq!("GetObject".to_string(), field_value);
         } else if field_name == "sdk_invocation_id" {
@@ -333,7 +333,7 @@ impl Visit for DdbTestVisitor {
         if field_name == "rpc.system" {
             assert_eq!("aws-api".to_string(), field_value);
         } else if field_name == "rpc.service" {
-            assert_eq!("dynamodb".to_string(), field_value);
+            assert_eq!("DynamoDB".to_string(), field_value);
         } else if field_name == "rpc.method" {
             assert_eq!("GetItem".to_string(), field_value);
         } else if field_name == "sdk_invocation_id" {

aws/sdk/integration-tests/telemetry/tests/metrics.rs

@@ -253,6 +253,7 @@ private fun baseClientRuntimePluginsFn(
         RuntimeType.forInlineFun("base_client_runtime_plugins", ClientRustModule.config) {
             val api = RuntimeType.smithyRuntimeApiClient(rc)
             val rt = RuntimeType.smithyRuntime(rc)
+            val serviceId = codegenContext.serviceShape.sdkId().lowercase().replace(" ", "")
             val behaviorVersionError =
                 "Invalid client configuration: A behavior major version must be set when sending a " +
                     "request or constructing a client. You must set it during client construction or by enabling the " +
@@ -266,7 +267,7 @@ private fun baseClientRuntimePluginsFn(
                     ::std::mem::swap(&mut config.runtime_plugins, &mut configured_plugins);
                     #{update_bmv}
 
-                    let default_retry_partition = ${codegenContext.serviceShape.sdkId().dq()};
+                    let default_retry_partition = ${serviceId.dq()};
                     #{before_plugin_setup}
 
                     let scope = ${codegenContext.moduleName.dq()};

aws/sdk/integration-tests/telemetry/tests/spans.rs

@@ -154,4 +154,4 @@ fun String.shapeId() = ShapeId.from(this)
 fun ServiceShape.serviceNameOrDefault(default: String) = getTrait<TitleTrait>()?.value ?: default
 
 /** Returns the SDK ID of the given service shape */
-fun ServiceShape.sdkId(): String = getTrait<ServiceTrait>()?.sdkId?.lowercase()?.replace(" ", "") ?: id.getName(this)
+fun ServiceShape.sdkId(): String = getTrait<ServiceTrait>()?.sdkId ?: id.getName(this)