Skip to content

Allow crc-fast to use version 1.8.0 #4443

@RobertSkawinski

Description

@RobertSkawinski

Currently the crc-fast crate version is pinned to 1.6.0, which breaks the backward compatibility implemented in crc-fast 1.8.0.
May I ask either to pin to crc-fast 1.8.0, or remove the version pinning?
VMs that does not passthrough host cpu information like proxmox in a HA setup with different cpu nodes are missing x86 features (SSE4.1 && PCLMULQDQ).

Related Ticket: #3981
Mentioned in file: rust-runtime/aws-smithy-checksums/Cargo.toml

I know there is a workaround for this, for example to patch inside Cargo.toml:

# Patch crc-fast to latest version (1.8.0+) which has improved runtime CPU feature detection
# and proper fallback to software implementation on older CPUs without SSE4.1/PCLMULQDQ
[patch.crates-io]
crc-fast = { git = "https://github.com/awesomized/crc-fast-rust" }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions