fix: Don't supply a default value when reading a non-optional value (#840)

Author: jbelkins

smithy-swift-codegen/src/main/kotlin/software/amazon/smithy/swift/codegen/integration/serde/member/MemberShapeDecodeGenerator.kt

@@ -72,7 +72,7 @@ open class MemberShapeDecodeGenerator(
             else -> renderMemberExp(member, isPayload)
         }
         val memberName = ctx.symbolProvider.toMemberName(member)
-        if (shapeContainingMembers.isUnionShape) {
+        if (decodingUnion) {
             writer.write("return .\$L(\$L)", memberName, readExp)
         } else if (shapeContainingMembers.isError) {
             writer.write("value.properties.\$L = \$L", memberName, readExp)
@@ -148,7 +148,7 @@ open class MemberShapeDecodeGenerator(
     }
 
     private fun readMethodName(baseName: String): String {
-        val extension = "".takeIf { shapeContainingMembers.isUnionShape } ?: "IfPresent"
+        val extension = "".takeIf { decodingUnion } ?: "IfPresent"
         return writer.format("\$L\$L", baseName, extension)
     }
 
@@ -158,6 +158,9 @@ open class MemberShapeDecodeGenerator(
     }
 
     private fun default(memberShape: MemberShape): String {
+        // If decoding the member of a union, then no default is needed.
+        if (decodingUnion) { return "" }
+
         val targetShape = ctx.model.expectShape(memberShape.target)
         val defaultTrait = memberShape.getTrait<DefaultTrait>() ?: targetShape.getTrait<DefaultTrait>()
         val requiredTrait = memberShape.getTrait<RequiredTrait>()
@@ -290,4 +293,6 @@ open class MemberShapeDecodeGenerator(
             )
         }
     }
+
+    private var decodingUnion: Boolean = shapeContainingMembers.isUnionShape
 }