chore!: Move CRT dependency from SmithyHTTPAPI to ClientRuntime (#1003)

Author: jbelkins

Package.swift

@@ -208,10 +208,7 @@ let package = Package(
         ),
         .target(
             name: "SmithyHTTPAPI",
-            dependencies: [
-                "Smithy",
-                .product(name: "AwsCommonRuntimeKit", package: "aws-crt-swift")
-            ]
+            dependencies: ["Smithy"]
         ),
         .target(
             name: "SmithyHTTPClient",

Sources/ClientRuntime/Networking/Http/CRT/Endpoint+CRT.swift

@@ -0,0 +1,43 @@
+//
+// Copyright Amazon.com Inc. or its affiliates.
+// All Rights Reserved.
+//
+// SPDX-License-Identifier: Apache-2.0
+//
+
+import enum AwsCommonRuntimeKit.EndpointProperty
+import struct Foundation.URLComponents
+import enum Smithy.ClientError
+import struct SmithyHTTPAPI.Endpoint
+import enum SmithyHTTPAPI.EndpointPropertyValue
+import struct SmithyHTTPAPI.Headers
+
+extension Endpoint {
+
+    public init(urlString: String,
+                headers: Headers = Headers(),
+                endpointProperties: [String: EndpointProperty]) throws {
+        guard let url = URLComponents(string: urlString)?.url else {
+            throw ClientError.unknownError("invalid url \(urlString)")
+        }
+
+        let properties = endpointProperties.mapValues(EndpointPropertyValue.init)
+        try self.init(url: url, headers: headers, properties: properties)
+    }
+}
+
+private extension EndpointPropertyValue {
+
+    init(_ endpointProperty: EndpointProperty) {
+        switch endpointProperty {
+        case .bool(let value):
+            self = .bool(value)
+        case .string(let value):
+            self = .string(value)
+        case .array(let values):
+            self = .array(values.map(EndpointPropertyValue.init))
+        case .dictionary(let dict):
+            self = .dictionary(dict.mapValues(EndpointPropertyValue.init))
+        }
+    }
+}

Sources/SmithyHTTPAPI/Endpoint.swift

@@ -5,7 +5,6 @@
 // SPDX-License-Identifier: Apache-2.0
 //
 
-import enum AwsCommonRuntimeKit.EndpointProperty
 import Foundation
 import Smithy
 
@@ -80,19 +79,6 @@ public struct Endpoint: Sendable, Equatable {
     }
 }
 
-extension Endpoint {
-    public init(urlString: String,
-                headers: Headers = Headers(),
-                endpointProperties: [String: EndpointProperty]) throws {
-        guard let url = URLComponents(string: urlString)?.url else {
-            throw ClientError.unknownError("invalid url \(urlString)")
-        }
-
-        let properties = endpointProperties.mapValues(EndpointPropertyValue.init)
-        try self.init(url: url, headers: headers, properties: properties)
-    }
-}
-
 extension Endpoint {
 
     /// Returns list of auth schemes

Sources/SmithyHTTPAPI/EndpointPropertyValue.swift

@@ -5,7 +5,6 @@
 // SPDX-License-Identifier: Apache-2.0
 //
 
-import enum AwsCommonRuntimeKit.EndpointProperty
 import Foundation
 import Smithy
 
@@ -22,21 +21,6 @@ public extension EndpointPropertyValue {
     init(_ bool: Bool) { self = .bool(bool) }
 }
 
-extension EndpointPropertyValue {
-    init(_ endpointProperty: EndpointProperty) {
-        switch endpointProperty {
-        case .bool(let value):
-            self = .bool(value)
-        case .string(let value):
-            self = .string(value)
-        case .array(let values):
-            self = .array(values.map(EndpointPropertyValue.init))
-        case .dictionary(let dict):
-            self = .dictionary(dict.mapValues(EndpointPropertyValue.init))
-        }
-    }
-}
-
 extension EndpointPropertyValue: ExpressibleByStringLiteral {
     public init(stringLiteral value: String) {
         self = .string(value)