feat!: Remove Hashable conformance from generated errors & models (#531)

Author: jbelkins

smithy-swift-codegen/src/main/kotlin/software/amazon/smithy/swift/codegen/CodegenVisitor.kt

@@ -25,7 +25,6 @@ import software.amazon.smithy.swift.codegen.integration.CustomDebugStringConvert
 import software.amazon.smithy.swift.codegen.integration.ProtocolGenerator
 import software.amazon.smithy.swift.codegen.integration.SwiftIntegration
 import software.amazon.smithy.swift.codegen.model.AddOperationShapes
-import software.amazon.smithy.swift.codegen.model.HashableShapeTransformer
 import software.amazon.smithy.swift.codegen.model.NestedShapeTransformer
 import software.amazon.smithy.swift.codegen.model.RecursiveShapeBoxer
 import software.amazon.smithy.swift.codegen.model.hasTrait
@@ -88,7 +87,6 @@ class CodegenVisitor(context: PluginContext) : ShapeVisitor.Default<Void>() {
         var resolvedModel = model
         resolvedModel = AddOperationShapes.execute(resolvedModel, settings.getService(resolvedModel), settings.moduleName)
         resolvedModel = RecursiveShapeBoxer.transform(resolvedModel)
-        resolvedModel = HashableShapeTransformer.transform(resolvedModel)
         resolvedModel = NestedShapeTransformer.transform(resolvedModel, settings.getService(resolvedModel))
         return resolvedModel
     }

smithy-swift-codegen/src/main/kotlin/software/amazon/smithy/swift/codegen/StructureGenerator.kt

@@ -14,7 +14,6 @@ import software.amazon.smithy.model.shapes.StructureShape
 import software.amazon.smithy.model.traits.ErrorTrait
 import software.amazon.smithy.model.traits.HttpErrorTrait
 import software.amazon.smithy.model.traits.RetryableTrait
-import software.amazon.smithy.swift.codegen.customtraits.HashableTrait
 import software.amazon.smithy.swift.codegen.customtraits.NestedTrait
 import software.amazon.smithy.swift.codegen.customtraits.SwiftBoxTrait
 import software.amazon.smithy.swift.codegen.integration.ProtocolGenerator
@@ -109,8 +108,7 @@ class StructureGenerator(
     private fun generateStruct() {
         writer.writeShapeDocs(shape)
         writer.writeAvailableAttribute(model, shape)
-        val needsHashable = if (shape.hasTrait<HashableTrait>()) ", ${SwiftTypes.Protocols.Hashable}" else ""
-        writer.openBlock("public struct \$struct.name:L: \$N$needsHashable {", SwiftTypes.Protocols.Equatable)
+        writer.openBlock("public struct \$struct.name:L: \$N {", SwiftTypes.Protocols.Equatable)
             .call { generateStructMembers() }
             .write("")
             .call { generateInitializerForStructure() }

smithy-swift-codegen/src/main/kotlin/software/amazon/smithy/swift/codegen/UnionGenerator.kt

@@ -71,8 +71,7 @@ class UnionGenerator(
         writer.writeShapeDocs(shape)
         writer.writeAvailableAttribute(model, shape)
         val indirectKeywordIfNeeded = if (needsIndirectKeyword(unionSymbol.name, shape)) "indirect " else ""
-        val hashable = hashableIfPossible()
-        writer.openBlock("public ${indirectKeywordIfNeeded}enum \$union.name:L: \$N$hashable {", "}\n", SwiftTypes.Protocols.Equatable) {
+        writer.openBlock("public ${indirectKeywordIfNeeded}enum \$union.name:L: \$N {", "}\n", SwiftTypes.Protocols.Equatable) {
             shape.allMembers.values.forEach {
                 writer.writeMemberDocs(model, it)
                 val enumCaseName = symbolProvider.toMemberName(it)
@@ -84,16 +83,6 @@ class UnionGenerator(
         }
     }
 
-    fun hashableIfPossible(): String {
-        shape.allMembers.values.forEach {
-            val enumCaseAssociatedType = symbolProvider.toSymbol(it)
-            if (enumCaseAssociatedType.name != "String") {
-                return ""
-            }
-        }
-        return ", ${SwiftTypes.Protocols.Hashable}"
-    }
-
     private fun needsIndirectKeyword(unionSymbolName: String, shape: UnionShape): Boolean {
         val membersReferencingUnion = shape.allMembers.values.filter {
             (symbolProvider.toSymbol(it).name).equals(unionSymbolName)

smithy-swift-codegen/src/main/kotlin/software/amazon/smithy/swift/codegen/customtraits/HashableTrait.kt

@@ -8,7 +8,6 @@ import org.junit.jupiter.api.Assertions
 import org.junit.jupiter.api.Test
 import software.amazon.smithy.model.Model
 import software.amazon.smithy.swift.codegen.model.AddOperationShapes
-import software.amazon.smithy.swift.codegen.model.HashableShapeTransformer
 import software.amazon.smithy.swift.codegen.model.NestedShapeTransformer
 import software.amazon.smithy.swift.codegen.model.RecursiveShapeBoxer
 
@@ -23,7 +22,6 @@ class UnionEncodeGeneratorTests {
         var resolvedModel = model
         resolvedModel = AddOperationShapes.execute(resolvedModel, settings.getService(resolvedModel), settings.moduleName)
         resolvedModel = RecursiveShapeBoxer.transform(resolvedModel)
-        resolvedModel = HashableShapeTransformer.transform(resolvedModel)
         resolvedModel = NestedShapeTransformer.transform(resolvedModel, settings.getService(resolvedModel))
         return resolvedModel
     }