fix: close http client on deinit of service client (#283)

Author: wooj2

smithy-swift-codegen/src/main/kotlin/software/amazon/smithy/swift/codegen/integration/HttpProtocolClientGenerator.kt

@@ -42,13 +42,13 @@ open class HttpProtocolClientGenerator(
     private val model: Model = ctx.model
     private val symbolProvider = ctx.symbolProvider
     private val serviceShape = ctx.service
-    private val clientGeneratorInitialization = HttpProtocolClientInitialization(ctx, writer, properties, serviceConfig)
+    private val httpProtocolServiceClient = HttpProtocolServiceClient(ctx, writer, properties, serviceConfig)
     fun render() {
         val serviceSymbol = symbolProvider.toSymbol(serviceShape)
         writer.addImport(SwiftDependency.CLIENT_RUNTIME.target)
         writer.addFoundationImport()
         httpProtocolCustomizable.renderInternals(ctx)
-        clientGeneratorInitialization.renderClientInitialization(serviceSymbol)
+        httpProtocolServiceClient.render(serviceSymbol)
         writer.write("")
         renderOperationsInExtension(serviceSymbol)
     }

smithy-swift-codegen/src/main/kotlin/software/amazon/smithy/swift/codegen/integration/HttpProtocolClientInitialization.kt renamed to smithy-swift-codegen/src/main/kotlin/software/amazon/smithy/swift/codegen/integration/HttpProtocolServiceClient.kt

@@ -3,15 +3,15 @@ package software.amazon.smithy.swift.codegen.integration
 import software.amazon.smithy.codegen.core.Symbol
 import software.amazon.smithy.swift.codegen.SwiftWriter
 
-open class HttpProtocolClientInitialization(
+open class HttpProtocolServiceClient(
     ctx: ProtocolGenerator.GenerationContext,
     private val writer: SwiftWriter,
     private val properties: List<ClientProperty>,
     private val serviceConfig: ServiceConfig
 ) {
     private val serviceName: String = ctx.settings.sdkId
 
-    fun renderClientInitialization(serviceSymbol: Symbol) {
+    fun render(serviceSymbol: Symbol) {
         writer.openBlock("public class ${serviceSymbol.name} {", "}") {
             writer.write("let client: SdkHttpClient")
             writer.write("let config: ${serviceConfig.typeName}")
@@ -35,6 +35,10 @@ open class HttpProtocolClientInitialization(
                 writer.write("self.config = config")
             }
             writer.write("")
+            writer.openBlock("deinit {", "}") {
+                writer.write("client.close()")
+            }
+            writer.write("")
             // FIXME: possible move generation of the config to a separate file or above the service client
             renderConfig(serviceSymbol)
         }

smithy-swift-codegen/src/test/kotlin/HttpProtocolClientGeneratorTests.kt

@@ -53,7 +53,11 @@ class HttpProtocolClientGeneratorTests {
                         self.decoder = config.decoder
                         self.config = config
                     }
-                
+
+                    deinit {
+                        client.close()
+                    }
+
                     public class ExampleClientConfiguration: ClientRuntime.Configuration {
                 
                         public static func `default`() throws -> ExampleClientConfiguration {