chore: Update to Smithy 1.52 (#843)

Author: jbelkins

Sources/SmithyHTTPAPI/Headers.swift

@@ -138,15 +138,7 @@ public struct Headers: Sendable {
     }
 
     public func exists(name: String) -> Bool {
-        guard headers.index(of: name) != nil else {
-            return false
-        }
-
-        guard let value = value(for: name) else {
-            return false
-        }
-
-        return !value.isEmpty
+        headers.index(of: name) != nil
     }
 
     /// The dictionary representation of all headers.

Sources/SmithyTestUtil/RequestTestUtil/HttpRequestTestBase.swift

@@ -334,7 +334,7 @@ open class HttpRequestTestBase: XCTestCase {
         }
 
         expected.headers.forEach { header in
-            XCTAssertTrue(actual.exists(name: header.name), file: file, line: line)
+            XCTAssert(actual.exists(name: header.name), "Header '\(header.name)' does not exist", file: file, line: line)
 
             guard actual.values(for: header.name) != header.value else {
                 XCTAssertEqual(actual.values(for: header.name), header.value, file: file, line: line)
@@ -345,14 +345,15 @@ open class HttpRequestTestBase: XCTestCase {
                 .joined(separator: ", ")
                 .components(separatedBy: .whitespaces)
                 .joined()
-            XCTAssertNotNil(actualValue, file: file, line: line)
+
+            XCTAssertNotNil(actualValue, "The actual header value for \(header.name) is not present", file: file, line: line)
 
             let expectedValue = header.value
                 .joined(separator: ", ")
                 .components(separatedBy: .whitespaces)
                 .joined()
-            
-            XCTAssertEqual(actualValue, expectedValue, file: file, line: line)
+
+            XCTAssert(actualValue == expectedValue, "Actual header '\(header.name)': '\(String(describing: actualValue))') Expected header: '\(String(describing: expectedValue))'", file: file, line: line)
         }
     }
 
@@ -391,7 +392,7 @@ open class HttpRequestTestBase: XCTestCase {
         for requiredHeaderName in expected {
             XCTAssertTrue(actual.exists(name: requiredHeaderName),
                           """
-                          expected required header not found: \(requiredHeaderName):
+                          required header not found: \(requiredHeaderName):
                           \(String(describing: actual.value(for: requiredHeaderName)))
                           """,
                           file: file,

Tests/ClientRuntimeTests/NetworkingTests/Http/HttpHeadersTests.swift renamed to Tests/SmithyHTTPAPITests/HeadersTests.swift

@@ -1,13 +1,14 @@
-/*
- * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
- * SPDX-License-Identifier: Apache-2.0.
- */
+//
+// Copyright Amazon.com Inc. or its affiliates.
+// All Rights Reserved.
+//
+// SPDX-License-Identifier: Apache-2.0
+//
 
 import SmithyHTTPAPI
 import XCTest
-import ClientRuntime
 
-class HttpHeadersTests: XCTestCase {
+class HeadersTests: XCTestCase {
 
     var headersAsDictionaryWithArray = [String: [String]]()
     var headersAsDictionary = [String: String]()
@@ -123,4 +124,26 @@ class HttpHeadersTests: XCTestCase {
         XCTAssertEqual(headerA, headerB)
         XCTAssertEqual(headerA.hashValue, headerB.hashValue)
     }
+
+    // MARK: - exists()
+
+    func test_exists_trueIfHeaderExists() {
+        let subject = Headers(["a": "abc"])
+        XCTAssertTrue(subject.exists(name: "a"))
+    }
+
+    func test_exists_falseIfHeaderDoesntExist() {
+        let subject = Headers(["a": "abc"])
+        XCTAssertFalse(subject.exists(name: "b"))
+    }
+
+    func test_exists_trueIfHeaderValueIsEmptyString() {
+        let subject = Headers(["a": ""])
+        XCTAssertTrue(subject.exists(name: "a"))
+    }
+
+    func test_exists_trueIfHeaderValueIsEmptyList() {
+        let subject = Headers(["a": []])
+        XCTAssertTrue(subject.exists(name: "a"))
+    }
 }

gradle.properties

@@ -3,7 +3,7 @@ kotlin.code.style=official
 # config
 
 # codegen
-smithyVersion=1.51.0
+smithyVersion=1.52.0
 smithyGradleVersion=0.6.0
 
 # kotlin

smithy-swift-codegen/src/main/kotlin/software/amazon/smithy/swift/codegen/integration/middlewares/providers/HttpHeaderProvider.kt

@@ -90,6 +90,9 @@ class HttpHeaderProvider(
             if (isBoxed) {
                 writer.openBlock("if let $memberName = value.$memberName {", "}") {
                     if (memberTarget is CollectionShape) {
+                        writer.openBlock("if \$L.isEmpty {", "}", memberName) {
+                            writer.write("items.add(name: \$S, value: \"\")", paramName)
+                        }
                         writer.openBlock("$memberName.forEach { headerValue in ", "}") {
                             renderHeader(memberTarget.member, "headerValue", paramName, true)
                         }