fix: testing and tls negotiation on linux (#306)

Author: kneekey23

Packages/ClientRuntime/LinuxMain.swift

@@ -23,7 +23,6 @@ public class CRTClientEngine: HttpClientEngine {
     private let maxConnectionsPerEndpoint: Int
 
     init(config: CRTClientEngineConfig = CRTClientEngineConfig()) {
-        AwsCommonRuntimeKit.initialize()
         self.maxConnectionsPerEndpoint = config.maxConnectionsPerEndpoint
         self.windowSize = config.windowSize
         self.logger = SwiftLogger(label: "CRTClientEngine")
@@ -32,6 +31,14 @@ public class CRTClientEngine: HttpClientEngine {
 
     private func createConnectionPool(endpoint: Endpoint) -> HttpClientConnectionManager {
         let tlsConnectionOptions = SDKDefaultIO.shared.tlsContext.newConnectionOptions()
+        #if os(Linux)
+        do {
+            try tlsConnectionOptions.setServerName(endpoint.host)
+        } catch let err {
+            logger.error("Server name was not able to be set in TLS Connection Options. TLS Negotiation will fail.")
+            logger.error("Error: \(err.localizedDescription)")
+        }
+        #endif
         let socketOptions = SocketOptions(socketType: .stream)
         let options = HttpClientConnectionOptions(clientBootstrap: SDKDefaultIO.shared.clientBootstrap,
                                                   hostName: endpoint.host,

Packages/ClientRuntime/Sources/Networking/Http/CRT/CRTClientEngine.swift

@@ -82,6 +82,7 @@ class DataObjectSerializationTests: XCTestCase {
             // encoded length is not a multiple of 4
             "Zm9vY=",
             // invalid padding
+            // TODO: this does not pass on Linux, it is unclear of this is in fact an invalid amount of padding.
             "Zm9vY==="
         ]
 

Packages/ClientRuntime/Tests/ClientRuntimeTests/SerializationTests/SerializationUtilsTests/DataObjectSerializationTests.swift

@@ -80,7 +80,7 @@ class MiddlewareStackTests: XCTestCase {
 
     func testFullBlownOperationRequestWithClientHandler() {
         let httpClientConfiguration = HttpClientConfiguration()
-        let clientEngine = try! CRTClientEngine()
+        let clientEngine = CRTClientEngine()
         let httpClient = SdkHttpClient(engine: clientEngine, config: httpClientConfiguration)
 
         let builtContext = HttpContextBuilder()

Packages/ClientRuntime/Tests/MiddlewareTests/MiddlewareStackTests.swift

@@ -14,7 +14,7 @@ class CRTClientEngineIntegrationTests: NetworkingTestUtils {
     override func setUp() {
         super.setUp()
         let httpClientConfiguration = HttpClientConfiguration()
-        let crtEngine = try! CRTClientEngine()
+        let crtEngine = CRTClientEngine()
         httpClient = SdkHttpClient(engine: crtEngine, config: httpClientConfiguration)
     }
 
@@ -44,15 +44,15 @@ class CRTClientEngineIntegrationTests: NetworkingTestUtils {
         wait(for: [expectation], timeout: 10.0)
     }
 
-    func testMakeHttpPostRequest() {
+    func testMakeHttpPostRequest() throws {
         //used https://httpbin.org
         let expectation = XCTestExpectation(description: "Request has been completed")
         var headers = Headers()
         headers.add(name: "Content-type", value: "application/json")
         headers.add(name: "Host", value: "httpbin.org")
         let body = TestBody(test: "testval")
         let encoder = JSONEncoder()
-        let encodedData = try! encoder.encode(body)
+        let encodedData = try encoder.encode(body)
         let request = SdkHttpRequest(method: .post,
                                      endpoint: Endpoint(host: "httpbin.org", path: "/post"),
                                      headers: headers,
@@ -196,15 +196,15 @@ class CRTClientEngineIntegrationTests: NetworkingTestUtils {
         wait(for: [expectation], timeout: 20.0)
     }
 
-    func testMakeHttpStreamRequestFromData() {
+    func testMakeHttpStreamRequestFromData() throws {
         //used https://httpbin.org
         let expectation = XCTestExpectation(description: "Request has been completed")
         var headers = Headers()
         headers.add(name: "Content-type", value: "application/json")
         headers.add(name: "Host", value: "httpbin.org")
         let body = TestBody(test: "testval")
         let encoder = JSONEncoder()
-        let encodedData = try! encoder.encode(body)
+        let encodedData = try encoder.encode(body)
 
         let request = SdkHttpRequest(method: .post,
                                      endpoint: Endpoint(host: "httpbin.org", path: "/post"),

Packages/ClientRuntime/Tests/NetworkingTests/CRTClientEngineIntegrationTests.swift

@@ -4,6 +4,9 @@
  */
 
 import Foundation
+#if os(Linux)
+import FoundationNetworking
+#endif
 @testable import ClientRuntime
 
 class MockURLProtocol: URLProtocol {