Skip to content

Commit b707795

Browse files
authored
fix: Eliminate warning when model has only indirect properties (#958)
1 parent 3543923 commit b707795

File tree

1 file changed

+3
-1
lines changed
  • smithy-swift-codegen/src/main/kotlin/software/amazon/smithy/swift/codegen/integration/serde/struct

1 file changed

+3
-1
lines changed

smithy-swift-codegen/src/main/kotlin/software/amazon/smithy/swift/codegen/integration/serde/struct/StructDecodeGenerator.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import software.amazon.smithy.model.shapes.MemberShape
1010
import software.amazon.smithy.model.shapes.OperationShape
1111
import software.amazon.smithy.model.shapes.Shape
1212
import software.amazon.smithy.swift.codegen.SwiftWriter
13+
import software.amazon.smithy.swift.codegen.customtraits.SwiftBoxTrait
1314
import software.amazon.smithy.swift.codegen.integration.ProtocolGenerator
1415
import software.amazon.smithy.swift.codegen.integration.serde.member.MemberShapeDecodeGenerator
1516
import software.amazon.smithy.swift.codegen.model.ShapeMetadata
@@ -46,7 +47,8 @@ open class StructDecodeGenerator(
4647
if (members.isEmpty()) {
4748
writer.write("return \$N()", symbol)
4849
} else {
49-
writer.write("var value = \$N()", symbol)
50+
val decl = "let".takeIf { members.all { it.hasTrait<SwiftBoxTrait>() } } ?: "var"
51+
writer.write("\$L value = \$N()", decl, symbol)
5052
if (isUnwrapped) {
5153
writer.write("let reader = reader.parent ?? reader")
5254
}

0 commit comments

Comments
 (0)