fix(core/schema): fix http binding struct iteration

Author: kuhe

packages/core/src/submodules/protocols/HttpBindingProtocol.ts

@@ -66,63 +66,65 @@ export abstract class HttpBindingProtocol extends HttpProtocol {
       }
     }
 
-    const _input: any = {
-      ...input,
-    };
-
     for (const [memberName, memberNs] of ns.structIterator()) {
-      const memberTraits = memberNs.getMergedTraits();
-      const inputMember = (_input as any)[memberName] as any;
+      const memberTraits = memberNs.getMergedTraits() ?? {};
+      const inputMemberValue = (input as any)[memberName] as any;
 
       if (memberTraits.httpPayload) {
-        const isStreaming = memberNs.isStreaming();
-        if (isStreaming) {
-          const isEventStream = memberNs.isStructSchema();
-          if (isEventStream) {
-            // todo(schema)
-            throw new Error("serialization of event streams is not yet implemented");
+        if (inputMemberValue != null) {
+          const isStreaming = memberNs.isStreaming();
+          if (isStreaming) {
+            const isEventStream = memberNs.isStructSchema();
+            if (isEventStream) {
+              // todo(schema)
+              throw new Error("serialization of event streams is not yet implemented");
+            } else {
+              // streaming blob body
+              payload = inputMemberValue;
+            }
           } else {
-            // streaming blob body
-            payload = inputMember;
+            // structural/document body
+            serializer.write(memberNs, inputMemberValue);
+            payload = serializer.flush();
           }
-        } else {
-          // structural/document body
-          serializer.write(memberNs, inputMember);
-          payload = serializer.flush();
         }
       } else if (memberTraits.httpLabel) {
-        serializer.write(memberNs, inputMember);
-        const replacement = serializer.flush() as string;
-        if (request.path.includes(`{${memberName}+}`)) {
-          request.path = request.path.replace(
-            `{${memberName}+}`,
-            replacement.split("/").map(extendedEncodeURIComponent).join("/")
-          );
-        } else if (request.path.includes(`{${memberName}}`)) {
-          request.path = request.path.replace(`{${memberName}}`, extendedEncodeURIComponent(replacement));
+        if (inputMemberValue != null) {
+          serializer.write(memberNs, inputMemberValue);
+          const replacement = serializer.flush() as string;
+          if (request.path.includes(`{${memberName}+}`)) {
+            request.path = request.path.replace(
+              `{${memberName}+}`,
+              replacement.split("/").map(extendedEncodeURIComponent).join("/")
+            );
+          } else if (request.path.includes(`{${memberName}}`)) {
+            request.path = request.path.replace(`{${memberName}}`, extendedEncodeURIComponent(replacement));
+          }
         }
-        delete _input[memberName];
       } else if (memberTraits.httpHeader) {
-        serializer.write(memberNs, inputMember);
-        headers[memberTraits.httpHeader.toLowerCase() as string] = String(serializer.flush());
-        delete _input[memberName];
+        if (inputMemberValue != null) {
+          serializer.write(memberNs, inputMemberValue);
+          headers[memberTraits.httpHeader.toLowerCase() as string] = String(serializer.flush());
+        }
       } else if (typeof memberTraits.httpPrefixHeaders === "string") {
-        for (const [key, val] of Object.entries(inputMember)) {
-          const amalgam = memberTraits.httpPrefixHeaders + key;
-          serializer.write([memberNs.getValueSchema(), { httpHeader: amalgam }], val);
-          headers[amalgam.toLowerCase()] = serializer.flush() as string;
+        if (inputMemberValue != null) {
+          for (const [key, val] of Object.entries(inputMemberValue)) {
+            const amalgam = memberTraits.httpPrefixHeaders + key;
+            serializer.write([memberNs.getValueSchema(), { httpHeader: amalgam }], val);
+            headers[amalgam.toLowerCase()] = serializer.flush() as string;
+          }
         }
-        delete _input[memberName];
       } else if (memberTraits.httpQuery || memberTraits.httpQueryParams) {
-        this.serializeQuery(memberNs, inputMember, query);
-        delete _input[memberName];
+        if (inputMemberValue != null) {
+          this.serializeQuery(memberNs, inputMemberValue, query);
+        }
       } else {
         hasNonHttpBindingMember = true;
       }
     }
 
     if (hasNonHttpBindingMember && input) {
-      serializer.write(schema, _input);
+      serializer.write(schema, input);
       payload = serializer.flush() as Uint8Array;
     }