fix: allow endpoint params to be explicitly undefined if not required (#1618)

Author: kuhe

private/smithy-rpcv2-cbor-schema/src/endpoint/EndpointParameters.ts

@@ -25,5 +25,5 @@ export const commonParams = {
 } as const;
 
 export interface EndpointParameters extends __EndpointParameters {
-  endpoint?: string;
+  endpoint?: string | undefined;
 }

private/smithy-rpcv2-cbor-schema/src/schemas/schemas.ts

@@ -1,7 +1,7 @@
-const _B = "Blob";
-const _BL = "BlobList";
-const _BLo = "BooleanList";
-const _Bo = "Boolean";
+const _B = "Boolean";
+const _BL = "BooleanList";
+const _BLl = "BlobList";
+const _Bl = "Blob";
 const _By = "Byte";
 const _CE = "ComplexError";
 const _CNED = "ComplexNestedErrorData";

private/smithy-rpcv2-cbor/src/endpoint/EndpointParameters.ts

@@ -25,5 +25,5 @@ export const commonParams = {
 } as const;
 
 export interface EndpointParameters extends __EndpointParameters {
-  endpoint?: string;
+  endpoint?: string | undefined;
 }

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/endpointsV2/ParameterGenerator.java

@@ -132,16 +132,21 @@ public Map.Entry<String, String> getNameAndType() {
     public String toCodeString(boolean isClientContextParam) {
         String buffer = "";
         buffer += parameterName;
-        if (!required || hasDefault() || isClientContextParam) {
+        boolean optional = !required || hasDefault() || isClientContextParam;
+        if (optional) {
             buffer += "?";
         }
         buffer += ": ";
 
         if (parameterName.equals("endpoint") && isInputKey) {
             buffer += "string | Provider<string> | Endpoint | Provider<Endpoint> | EndpointV2 | Provider<EndpointV2>;";
         } else {
-            if (isClientContextParam) {
-                buffer += (tsParamType + "|" + "Provider<" + tsParamType + ">") + ";";
+            if (optional) {
+                if (isClientContextParam) {
+                    buffer += (tsParamType + " | undefined | Provider<" + tsParamType + " | undefined>") + ";";
+                } else {
+                    buffer += tsParamType + " | undefined;";
+                }
             } else {
                 buffer += tsParamType + ";";
             }

smithy-typescript-codegen/src/test/java/software/amazon/smithy/typescript/codegen/endpointsV2/EndpointsV2GeneratorTest.java

@@ -40,25 +40,30 @@ public void containsExtraContextParameter() {
         String ruleset = manifest.getFileString(CodegenUtils.SOURCE_FOLDER + "/endpoint/ruleset.ts").get();
 
         assertThat(ruleset, containsString(
-                "      },\n" +
-                "      \"Stage\": {\n" +
-                "        \"type\": \"String\",\n" +
-                "        \"required\": true,\n" +
-                "        \"default\": \"production\",\n" +
-                "      },\n"));
+            """
+                      },
+                      "Stage": {
+                        "type": "String",
+                        "required": true,
+                        "default": "production",
+                      },
+                """));
 
         String endpointParameters = manifest.getFileString(CodegenUtils.SOURCE_FOLDER + "/endpoint/EndpointParameters.ts").get();
 
         assertThat(endpointParameters, containsString(
-                "  return Object.assign(options, {\n" +
-                "    stage: options.stage ?? \"production\",\n" +
-                "    defaultSigningName: \"\",\n" +
-                "  });\n"));
+            """
+                  return Object.assign(options, {
+                    stage: options.stage ?? "production",
+                    defaultSigningName: "",
+                  });
+                """));
         assertThat(endpointParameters, containsString(
-                "export interface ClientInputEndpointParameters {\n" +
-                "  region?: string|Provider<string>;\n" +
-                "  stage?: string|Provider<string>;\n" +
-                "  endpoint?:"));
+            """
+                export interface ClientInputEndpointParameters {
+                  region?: string | undefined | Provider<string | undefined>;
+                  stage?: string | undefined | Provider<string | undefined>;
+                  endpoint?:"""));
     }
 
     private MockManifest testEndpoints(String filename) {