Circular imports transforms <-> Uint8ArrayBlobAdapter

[major-major-major-major]

Some bundlers (rollup in my case) mark the circular dependency in your package as an error:

This can be silenced by adding it to knownCircularDependencies in the Rollup configuration, but that isn't too pretty and needs to be done for every version.

• transforms imports Uint8ArrayBlobAdapter

• Uint8ArrayBlobAdapter imports transforms

• https://github.com/smithy-lang/smithy-typescript/blob/main/packages/util-stream/src/blob/transforms.ts#L4

• https://github.com/smithy-lang/smithy-typescript/blob/main/packages/util-stream/src/blob/Uint8ArrayBlobAdapter.ts#L1

Is this something that could be resolved?
Maybe by adding the mutate function as a third parameter to transformFromString?
Or by moving the two functions in transforms.ts to Uint8ArrayBlobAdapter.ts, not exporting them?

Thanks!

[major-major-major-major]

There are a few more, should I open new issues for the following?:

• evaluateExpression imports callFunction and vice versa.
• getEndpointProperty <-> getEndpointProperties
• evaluateRules <-> evaluateTreeRule

[kuhe]

No need for other tickets, if or when we get around to fixing this it will be detected by automation and blocked by automation.

[kuhe]

circular imports were removed in the latest available versions of @smithy packages e.g. https://www.npmjs.com/package/@smithy/util-stream/v/4.5.3

[major-major-major-major]

Great! Thank you very much!

Just to make sure: the throw is commented out on purpose?: https://github.com/aws/aws-sdk-js-v3/blob/main/scripts/compilation/Inliner.js#L190

Edit:
Nvm, here its not: https://github.com/smithy-lang/smithy-typescript/blob/main/scripts/compilation/Inliner.js#L186

Sorry, I'm not very familiar with this package, or the linked one, just scrolled over the changes in the linked MRs and deemed that odd.

[kuhe]

The AWS SDK is a first party dependent of the Smithy TypeScript code generator and @smithy package group. The commit accidentally commented out the circular dependency check, but I am now testing it with a new PR: aws/aws-sdk-js-v3#7432.

I don't think the AWS SDK (@aws-sdk/*) contains any circular dependencies. The ones that did exist in the @smithy packages have been removed.