fix(codegen): allow empty string field values for headers #1412
+60
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
reviewed
Sep 20, 2024
...c/main/resources/software/amazon/smithy/typescript/codegen/integration/http-binding-utils.ts
Outdated
Show resolved
Hide resolved
nvllkwng
reviewed
Sep 20, 2024
...c/main/resources/software/amazon/smithy/typescript/codegen/integration/http-binding-utils.ts
Outdated
Show resolved
Hide resolved
kuhe
force-pushed
the
fix/missingMeta
branch
2 times, most recently
from
de82c5f to
fa9ecaf
Compare
kuhe
force-pushed
the
fix/missingMeta
branch
from
fa9ecaf to
e547d6a
Compare
kuhe
approved these changes
Sep 23, 2024
This was referenced Sep 23, 2024
Merged
kstich
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires: #1414
Issue #, if available:
Internal JS-5444
Description of changes:
allows headers to have empty values.
for more details, relevant RFC: https://www.rfc-editor.org/rfc/rfc9110.html#section-5.5
upstream of this: smithy-lang/smithy#2403 protocol test change
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.