Skip to content

fix: add uuid types when adding uuid #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: add uuid types when adding uuid #1428

merged 1 commit into from
Oct 8, 2024

Conversation

@kuhe
Copy link
Contributor

@kuhe kuhe commented Oct 8, 2024 •
edited
Loading

uuid doesn't import its own types package and is under an older system of having types in the @types/ organization.

This imports those types when importing uuid.

@kuhe kuhe requested review from a team as code owners October 8, 2024 17:18
@kuhe kuhe requested a review from haydenbaker October 8, 2024 17:18
@kuhe kuhe merged commit 72faecc into smithy-lang:main Oct 8, 2024
11 checks passed
@kuhe kuhe deleted the fix/uuid branch October 8, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@haydenbaker haydenbaker haydenbaker approved these changes

@siddsriv siddsriv siddsriv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kuhe @haydenbaker @siddsriv