Skip to content

chore: switch NPM publishing token source #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2025
Merged

chore: switch NPM publishing token source #1494

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
022c4b7
chore: switch NPM publishing token source
kuhe Jan 7, 2025
5884124
delete .changeset/olive-lies-bake.md
kuhe Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/olive-lies-bake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@smithy/util-stream-browser": patch
---

no-op change to test publisher
6 changes: 3 additions & 3 deletions .github/workflows/release-npm-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
uses: aws-actions/configure-aws-credentials@v4
with:
aws-region: us-west-2
role-to-assume: ${{ secrets.ROLE_TO_ASSUME }}
role-to-assume: ${{ secrets.JS_TEAM_ROLE_TO_ASSUME }}
role-session-name: SmithyTypeScriptGitHubRelease
audience: sts.amazonaws.com
- name: Commit
Expand All @@ -46,9 +46,9 @@ jobs:
id: token
if: steps.commit.outcome == 'success'
run: |
aws configure --profile token set role_arn ${{ secrets.TOKEN_ROLE }}
aws configure --profile token set role_arn ${{ secrets.JS_TEAM_TOKEN_ROLE }}
aws configure --profile token set credential_source Environment
npm_token=$(aws secretsmanager get-secret-value --region us-west-2 --secret-id=SMITHY_PUBLISH_npmToken --query SecretString --output text --profile token)
npm_token=$(aws secretsmanager get-secret-value --region us-west-2 --secret-id=smithy-typescript-npm-token --query SecretString --output text --profile token)
Copy link
Contributor Author

@kuhe kuhe Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this step was tested in #1493

echo "::add-mask::$npm_token"
echo "NPM_TOKEN=$npm_token" >> $GITHUB_ENV
- name: Stage Release
Expand Down
Loading