Make IAM resource name validation case-insensitive

Author: kstich

smithy-aws-iam-traits/src/main/java/software/amazon/smithy/aws/iam/traits/IamResourceTraitConflictingNameValidator.java

@@ -9,6 +9,7 @@
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import java.util.stream.Collectors;
 import software.amazon.smithy.model.Model;
@@ -38,16 +39,17 @@ private List<ValidationEvent> validateService(TopDownIndex topDownIndex, Service
         List<ValidationEvent> events = new ArrayList<>();
         Map<String, List<ShapeId>> resourceMap = new HashMap<>();
         for (ResourceShape resource : topDownIndex.getContainedResources(service)) {
-            String resourceName = IamResourceTrait.resolveResourceName(resource);
+            String resourceName = IamResourceTrait.resolveResourceName(resource).toLowerCase(Locale.US);
             resourceMap.computeIfAbsent(resourceName, k -> new ArrayList<>()).add(resource.getId());
         }
         resourceMap.entrySet()
                 .stream()
                 .filter(entry -> entry.getValue().size() > 1)
                 .map(entry -> error(service,
                         String.format(
-                                "Multiple IAM resources defined with the same IAM resource name is not allowed in a service "
-                                        + "closure, but found multiple resources named `%s` in the service `%s`: [%s]",
+                                "Multiple IAM resources defined with the same IAM resource name is not allowed in a "
+                                        + "service closure, but found multiple resources case-insensitively named `%s` "
+                                        + "in the service `%s`: [%s]",
                                 entry.getKey(),
                                 service.getId(),
                                 tickedList(entry.getValue()))))

smithy-aws-iam-traits/src/test/resources/software/amazon/smithy/aws/iam/traits/errorfiles/iam-resources/duplicate-iam-resources-name.errors

@@ -1 +1 @@
-[ERROR] smithy.example#MyService: Multiple IAM resources defined with the same IAM resource name is not allowed in a service closure, but found multiple resources named `Beer` in the service `smithy.example#MyService`: [`smithy.example#BadIamResourceName1`, `smithy.example#BadIamResourceName2`, `smithy.example#Beer`] | IamResourceTraitConflictingName
+[ERROR] smithy.example#MyService: Multiple IAM resources defined with the same IAM resource name is not allowed in a service closure, but found multiple resources case-insensitively named `beer` in the service `smithy.example#MyService`: [`smithy.example#BadIamResourceName1`, `smithy.example#BadIamResourceName2`, `smithy.example#Beer`] | IamResourceTraitConflictingName

smithy-aws-iam-traits/src/test/resources/software/amazon/smithy/aws/iam/traits/errorfiles/iam-resources/duplicate-iam-resources-name.smithy

@@ -21,7 +21,7 @@ resource Beer {}
 @aws.iam#iamResource(name: "Beer")
 resource BadIamResourceName1 {}
 
-@aws.iam#iamResource(name: "Beer")
+@aws.iam#iamResource(name: "beer")
 resource BadIamResourceName2 {}
 
 @aws.iam#iamResource(name: "shouldNotThrowErrorSecond")