Fix message in RemovedServiceError diff event

Author: kstich

.changes/README.md

@@ -20,6 +20,17 @@ a change suggestion that adds it.
 
 To get details about optional arguments to the command, run `new-change -h`.
 
+#### Types of changes
+
+The following are the types defined for pull requests:
+
+* **feature** - A larger feature or change in behavior, usually resulting in a
+  minor version bump.
+* **bugfix** - Fixing a bug in an existing code path.
+* **documentation** - A documentation-only change.
+* **break** - A breaking change, be it a break-fix or a breaking feature change.
+* **other** - Any change that does not fit into another category.
+
 ### When Releasing Smithy
 
 Before performing a release, ensure that every pull request since the last
@@ -150,7 +161,7 @@ These actions will be performed by the `amend` script.
 #### Releases
 
 A manually-triggered GitHub workflow will bump the Smithy version, gather the
-pending changes into a release defintiion, and render the new changelog. It will
+pending changes into a release definition, and render the new changelog. It will
 then create a pull request with these changes.
 
 The workflow will have an input argument to select either a major or minor version

.changes/next-release/bugfix-41a8f20528d30c560c99f1a849e88323833916ca.json

@@ -0,0 +1,7 @@
+{
+  "type": "bugfix",
+  "description": "Fix message in RemovedServiceError diff event",
+  "pull_requests": [
+    "[#2823](https://github.com/smithy-lang/smithy/pull/2823)"
+  ]
+}

smithy-diff/src/main/java/software/amazon/smithy/diff/evaluators/RemovedServiceError.java

@@ -38,8 +38,8 @@ private List<ValidationEvent> createErrorViolations(ChangedShape<ServiceShape> c
                                 "The `%s` error was removed from the `%s` service. This means that it "
                                         + "is no longer considered an error common to all operations within the "
                                         + "service.",
-                                change.getShapeId(),
-                                id)));
+                                id,
+                                change.getShapeId())));
             }
         }
 

smithy-diff/src/test/java/software/amazon/smithy/diff/evaluators/RemovedServiceErrorTest.java

@@ -5,6 +5,7 @@
 package software.amazon.smithy.diff.evaluators;
 
 import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.containsString;
 import static org.hamcrest.Matchers.equalTo;
 
 import java.util.List;
@@ -40,6 +41,10 @@ public void detectsRemovedErrors() {
         List<ValidationEvent> events = ModelDiff.compare(modelA, modelB);
 
         // Emits one even for both removals.
-        assertThat(TestHelper.findEvents(events, "RemovedServiceError").size(), equalTo(2));
+        List<ValidationEvent> foundEvents = TestHelper.findEvents(events, "RemovedServiceError");
+        assertThat(foundEvents.size(), equalTo(2));
+        for (ValidationEvent foundEvent : foundEvents) {
+            assertThat(foundEvent.getMessage(), containsString("error was removed from the `foo.baz#S` service"));
+        }
     }
 }