Add "Since" suffix to timestamp linter

Author: kstich

docs/source-2.0/guides/model-linters.rst

@@ -777,6 +777,7 @@ A name is assumed to represent a time value if it:
 * Begins or ends with the word "date"
 * Ends with the word "at"
 * Ends with the word "on"
+* Ends with the word "since"
 * Contains the exact string "timestamp" or "Timestamp"
 
 For the purpose of this validator, words are matched case insensitively. Words

smithy-linters/src/main/java/software/amazon/smithy/linters/ShouldHaveUsedTimestampValidator.java

@@ -45,6 +45,7 @@
  *     <li>Begins or Ends with the word "date"</li>
  *     <li>Ends with the word "at"</li>
  *     <li>Ends with the word "on"</li>
+ *     <li>Ends with the word "since"</li>
  * </ul>
  *
  * <p>When checking for one of the above words, the first character may be
@@ -87,7 +88,8 @@ public Provider() {
             Pattern.compile("^.*([a-z]T|_[Tt])ime$"), // ends with the word "time"
             Pattern.compile("^.*([a-z]D|_[Dd])ate$"), // ends with the word "date"
             Pattern.compile("^.*([a-z]A|_[Aa])t$"), // ends with the word "at"
-            Pattern.compile("^.*([a-z]O|_[Oo])n$") // ends with the word "on"
+            Pattern.compile("^.*([a-z]O|_[Oo])n$"), // ends with the word "on"
+            Pattern.compile("^.*([a-z]S|_[Ss])ince$") // ends with the word "since"
     );
 
     private final List<Pattern> patterns = new ArrayList<>(DEFAULT_PATTERNS);

smithy-linters/src/test/resources/software/amazon/smithy/linters/errorfiles/should-have-used-timestamp.errors

@@ -11,6 +11,7 @@
 [DANGER] example.namespace#OopsString: Shape `OopsString` is named like a timestamp but is a `string` shape. | ShouldHaveUsedTimestamp
 [DANGER] example.namespace#StartedAt: Shape `StartedAt` is named like a timestamp but is a `string` shape. | ShouldHaveUsedTimestamp
 [DANGER] example.namespace#StartedOn: Shape `StartedOn` is named like a timestamp but is a `string` shape. | ShouldHaveUsedTimestamp
+[DANGER] example.namespace#IfModifiedSince: Shape `IfModifiedSince` is named like a timestamp but is a `string` shape. | ShouldHaveUsedTimestamp
 [DANGER] example.namespace#Structure$OopsStructureMember: Member `OopsStructureMember` is named like a timestamp but references a `string` shape | ShouldHaveUsedTimestamp
 [DANGER] example.namespace#TaggedUnion$OopsTaggedUnionMember: Member `OopsTaggedUnionMember` is named like a timestamp but references a `string` shape | ShouldHaveUsedTimestamp
 [DANGER] example.namespace#Time: Shape `Time` is named like a timestamp but is a `string` shape. | ShouldHaveUsedTimestamp

smithy-linters/src/test/resources/software/amazon/smithy/linters/errorfiles/should-have-used-timestamp.json

@@ -70,6 +70,9 @@
         },
         "example.namespace#StartedOn": {
             "type": "string"
+        },
+        "example.namespace#IfModifiedSince": {
+            "type": "string"
         }
     },
     "metadata": {