Support Java Interruption in model loading

[kubukoz]

It would be great to have some interruption points in model loading, to allow for callers to possibly save some time on redundant loads whose result isn't going to be used anyway.

At the very least, a check before validators would be a great start. Presumably, validators themselves could opt into being interruptible as well.

[JordonPhillips]

In what cases are you seeing redundant model loading? Maybe dependencies?

[kubukoz]

It's not so much something I'm seeing, it's more like something I'm making. Let me explain.

For example, if I'm making a tool that reloads the model on config file change, and the file changes while another load is already happening, I'd like to interrupt the ongoing load. This is easy to do when the loading code checks for Thread.isInterrupted.

[JordonPhillips]

Seems reasonable. Checking in the validators will be a bit tricky since right now they're run in parallel streams, which iirc don't handle interrupts well. Before loading models and before doing validation as a whole should work fine though

[sugmanue]

I'm not sure if this is worth doing, it will be unreliable and complicated. Is it your model long enough that it will worth doing? Can't you wait till the previous one is done and spin a new one when is done?

[kubukoz]

Is it your model long enough that it will worth doing?

It's several seconds (and keeps growing with new validators, new shapes etc.)

Can't you wait till the previous one is done and spin a new one when is done?

That's the current workaround, yeah.